Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ifaze-0001Cx-L6 for pgsql-bugs@arkaria.postgresql.org; Fri, 13 Dec 2019 02:47:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ifazc-0008D6-78 for pgsql-bugs@arkaria.postgresql.org; Fri, 13 Dec 2019 02:47:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ifaza-0008Cz-Ho for pgsql-bugs@lists.postgresql.org; Fri, 13 Dec 2019 02:47:47 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ifazW-00050K-90 for pgsql-bugs@lists.postgresql.org; Fri, 13 Dec 2019 02:47:46 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D7C4822680; Thu, 12 Dec 2019 21:47:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 12 Dec 2019 21:47:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=CcBuQ1mSX+y4kyp53gbaQCpXNIU 9dkM/xUUlerG4gtM=; b=j3vQ/sYM1rIQrv3s3BMJ+MTMIvDMc+jpEKQ6ubGauDa ZeEGfEoIw154PJG5fWwEGCOM1tXpIqj4F7N89OCXB6pkYrZR1KGZud+jvZOtnAuI YKIGfIS1IMTnHNs8W/TM/G0Myi0nmENw1ps93dbW3gMjJWNSbq/yX1YGqK/QjZXh SK7f373VmCqBCN3cT26XhWLW5yt6aOi2FpP1pGVOu2VpiZKLnuu5z0ow0USA+CZR CbBKEQZ1AwAAXtVoF0r81EXFfQxKyrOOiQQ1PkeY1zzUwqgW4rRGbba2zqP4CNUk ZYOtfCAal39fWABZKMwl2+gqQ7pbPqxN7AsGwBZYgpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CcBuQ1 mSX+y4kyp53gbaQCpXNIU9dkM/xUUlerG4gtM=; b=PejZwFpviGRHdM/oz6Rgz5 sb99N30cjesQp88/EMZpmWmnx12wp92U5vzEp1CeJpD8QH50QWHE/KvfS64Fcmdm lERLAAaLVjYHY9pZOOQ7swnSmNaabJWcQaXghILypwlRAqAu/uBO0ss7i17uoVKd QHS2n+7ZSZiKUOCZg7b8+ZbP1/pKuA0rW8nn7rEWVt0LmkoJEmRPNVUsCh/yHEaN JJJCx7glC6FIrS/Nby7i0J55Ez02eME95+qteTVBnOcLi+PWGzx13CpL87qi6an7 CAd60L8zuyE2i0gt4fk6ZVf32gEuNkEhpg0buxWJF6bSpz4f1FrmWZt0XKV8Ahtg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelkedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepuddukedrvdeguddrvdehuddrudehgeenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (mp76f1fb9a.ap.nuro.jp [118.241.251.154]) by mail.messagingengine.com (Postfix) with ESMTPA id B2C568005C; Thu, 12 Dec 2019 21:47:36 -0500 (EST) Date: Fri, 13 Dec 2019 11:47:33 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Andres Freund , Tom Lane , Manuel Rigger , PostgreSQL mailing lists Subject: Re: REINDEX CONCURRENTLY unexpectedly fails Message-ID: <20191213024733.GC1942@paquier.xyz> References: <20191120035408.GA4243@paquier.xyz> <20191212201108.GA2944@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: <20191212201108.GA2944@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 12, 2019 at 05:11:08PM -0300, Alvaro Herrera wrote: > I liked Andres' original naming suggestion better FWIW. With this, one > wonders "concurrently what?" I did not like the "creation" part from the original suggestion :) IndexCreationSupportsConcurrent() called from a place where an index is dropped does not sound very consistent. > Some suggestions, > "RelationSupportsConcurrentIndexing" or > "IndexSupportsConcurrently". Maybe replace the "ing" in the first or > "ly" in the second with "DDL" or "Ops". (Also, if it's just about > indexes and appears in index.h, why did you use the prefix "Relation"?) RelationSupportsConcurrentIndexing sounds like a good compromise to me. The reasoning behind using relation is that this check can be used for an index or its parent relation. -- Michael --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3y+8UACgkQnvQgOdby QH14Uw//a2Gy7PgH+huPubGM+K49HuYrETmBtVPACkr8RpJ/WSCK58SydDSjhvGv xnbkTHfoKarNSKDdUCgnfKXJTR2goc2TNBQUbqDqNHSyr/NtXBzo+IMT63K73h8y if5/2CUaonxZiT/NLffNDmDA8wV19AWvO7zrCR/RiwbX0O0WI1MlD9+HhEmwPnID VMveL7abkTPXqHYIb3dpisgvHxq9Z5p86ITNBax5y2UKf5xWBZFpBFhRTzB3SRAf 4koYVJ1t4jzSs8eJoDo5yCqBbepv+AfmfKrV7HwBU1Kf8BE4WnNWBEqldWjw2nqI 8xaOtJq/st5Na5JtJbNVg6IH12A9ilwf5ANFpVRZ0GPn975Ci6kOI7vDwiZHB8E3 OK1yi1Mk1k629NlyUzegY5jcKC8P50AWJKV+NV3bL/lqgeaL5G3og8ne0lVwmg8e BoQ2iefpCpRQpkw+rT0kefmo4BEUK0v2WOJZ8woWSDUFV20Zt/wDAKBD8vOi/YTp H76wjRsS2I/qs0V4M2s7leNTdLCot+8Cgn1w9jPGy6LRnug5tgBjlY7KKB25Yffu /IMxoO2ksw/860h8129+RNG/WpxGxWanxWJlZ/0atCn9jpfE0i1o7GywXb5kGfTp 1FgHMLbTD47ZC25ws/OkjKbwWk+IyoJhmhlWgKTZhP8Gj6AdLj8= =BKqX -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--