Date: Fri, 27 Dec 2019 17:03:33 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes
 required quotes
Message-ID: <20191227200333.GA20015@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <28922.1577474837@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Dec-27, Tom Lane wrote:

> I wrote:
> > [ psql-filename-completion-fixes-2.patch ]
> 
> The cfbot noted this was broken by the removal of pg_config.h.win32,
> so here's a new version rebased over that.  No changes other than
> adjusting the MSVC autoconf-substitute code.

Works well for me.

One minor thing I noticed is that if I enter
\copy t from '/tmp/t'<tab>
and I have files /tmp/t and /tmp/tst then it removes the ending quote.
I can live with that, since the tab there is pointless anyway.
(The unpatched version removes *both* quotes.  The quotes there are not
mandatory, but the new version works better when there are files with
whitespace in the name.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services