Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irHz3-00063z-Ms for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Jan 2020 08:55:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1irHz1-0000u4-5F for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Jan 2020 08:55:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irHz0-0000tx-TS for pgsql-bugs@lists.postgresql.org; Tue, 14 Jan 2020 08:55:30 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irHyu-0006Qn-F2 for pgsql-bugs@lists.postgresql.org; Tue, 14 Jan 2020 08:55:28 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 10D982249C; Tue, 14 Jan 2020 03:55:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 14 Jan 2020 03:55:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=1vprFCNT7UOI9N3+NaIfNQgJ28X W17UkF4WgWufOUBc=; b=Tx/dG4IMfbb7x3tyQbmZCUzt79JozNFf9IX39109dsf 8ZJXGdfr92NGbI2SkRlcm0LoMJKXN4XM///CAFIk8JwqL9+vFwEQ5ZA4Vqq7MQ3X sO0uxF/Zga6fD0KXnEt6ySaVirjuVnoGmvPLChweIZGs/PsUtLwFA3FuFdRzISY1 F73GYbJs50WAVXWtrqJnb4rvwfNuHvosdsf1B/LnI7+jnAqT7/hCW+0vVX/T7VEn ZrpCkIjBtZQBVy2/REsQ1RNFhYiia2K0b3zORhtuxyfjw88YBdXSnSImyscJBBqJ l26+ACBsmiDlg0mN0ldcJn2vyK+lldBrzwD+cUS/QOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1vprFC NT7UOI9N3+NaIfNQgJ28XW17UkF4WgWufOUBc=; b=wCx9+VfhNT4RLpni7WolcB M2kAbyo+sFgpYz1QKn6OBRrjP0VlFPW5lJawagoUhiWjRezw9N8fzLeuPhaiwxTY 0X5K+LL+TfegyTvP6A3BRs8NuiBHbNSG+FwUZGl/mcPywSx/s8/6rjM4aUGGRuTm XblXbAafvtWQs3lEdbxQDcsKoT6G6LRycRMNpGoabLSChS3N+0FcJS1KEzG6nDKi kmvyN9kz/EUYsPfrSD+5eN0folq7Xw12nDn9H5Z9Lvyvosq/0P85BosHw1sz7sNY fLYsb0G759mbcMezTd6mkHzKXiO/L+7pClgnXbBJ3pSFqsOo4LL4lKa3+driQWBA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdejuddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgr rhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 9AD1C30602DE; Tue, 14 Jan 2020 03:55:13 -0500 (EST) Date: Tue, 14 Jan 2020 17:55:05 +0900 From: Michael Paquier To: Jobin Augustine Cc: Heikki Linnakangas , Oleksandr Shulgin , pgsql-bugs@lists.postgresql.org Subject: Re: libpq parameter parsing problem Message-ID: <20200114085505.GA83028@paquier.xyz> References: <22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi> <20200109043809.GK2251@paquier.xyz> <20200114060317.GF1515@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 14, 2020 at 12:01:43PM +0530, Jobin Augustine wrote: > Yes, agree, readability is better with that modification. > Attaching a modified patch. (Please always top-post, this is the style of the PostgreSQL community mailing lists). The new patch looks good to me, let's see if others have extra thoughts to share. If not, I'll try to commit it. -- Michael --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4dgekACgkQnvQgOdby QH0+Lg/+P6R23TDR97un//3gvWkAealcmTOWUnBtjVHyakPX3bO+Sj9N3CAlgtwS A4vvdEQGw6y2+ZEQFu8t4QKVprivTLLgXAozmNPmN2RqQIRvM6uuvg2Ri2O+pT1t 67K+VwAxDL34Knk3TqTzd2mYLkZlwvJa8weZxerOj0hhsm7tVEjQOXhhxqlOZzv5 VI0bld8d1C6TX6y+uUyfmYSeRaxJ6i7Ouhsil7nLnj/HUK3RIr/WwtDpyWFPcCrF VLuy+XFY2/dY3J95F+EMl6OuSwC19PbnTSTmMsYXwAafWuMwT7xOVm1/rf7GQsk3 E2u8KlqRPhV1UrYVm7wQ2Rs4Ikw1/gICiwFgPZX2ZOXBl5M1oEQsQn3ugpS4d6Qc 8htEUuI5L9p3okYjmt3tdwSutuvOQ1qYOpqb334MuR41zeRYAZOpA6Wc/QEpnL2M uEePGpfSC7mPrBoFIhgoBVroVh0M+uXjLYsD6gmjiBOqxpc5n0I44MLVW1dkpvPO GJlzSxl0HBVmVlDr+PMcQc487ybas2rboKIKqligVO6JRavISt0hksm+B4WEwhb3 BlA79XRPCuREgUAJviS+SfNgpP3QUA5gIUGFUVi1aW7FJtzYZ7iqrG6EtcqbycBM HoRCwCaIvUMrSGlX9c54hq0b/aG+DpJ4YTmEHwEKtgsMqCAHQts= =U1XQ -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--