Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irUBk-0008RM-DG for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Jan 2020 21:57:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1irUAl-0007nU-4Y for pgsql-bugs@arkaria.postgresql.org; Tue, 14 Jan 2020 21:56:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irUAk-0007nN-P5 for pgsql-bugs@lists.postgresql.org; Tue, 14 Jan 2020 21:56:26 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1irUAg-00014H-BO for pgsql-bugs@lists.postgresql.org; Tue, 14 Jan 2020 21:56:26 +0000 Received: by mail-qk1-x741.google.com with SMTP id j9so13775836qkk.1 for ; Tue, 14 Jan 2020 13:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=ST57yGlztQY5HuDhw/3egvrqlGNqXWTeYRMdeWhrhPY=; b=D9wTFx4S7g8cKya54gHKomLA4MiW7u/t0ecszuwS2Wh2HU8gJMhtUgYhFWX14s4a1Y 9k9rP0aPa0If3xij+M8HKzimoHqsGbKCtkglBW8wZxcZg/MjLTwg0Fv4d85E9nEkoO8W OQLXteg7Wo9RuXDMy1aLLZyDLwtGU5LiBpineCjOKtRVhU6Kzw1nefzPdIfbhZGcDiTO gvJOVvMQzxNkMlXsDEdIxFnAY7fEDF8Bs1C4pigWt23W+aascdMHecnmYvTiVNjlqz9y wTVOeCnVZsnzSOqKq7TlIu0IO7JzNHQ0fD/30RvONvSXayxqS3E6dHIL1oZN6DfFgoiq NaKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ST57yGlztQY5HuDhw/3egvrqlGNqXWTeYRMdeWhrhPY=; b=TlVc7Mk0i6OSt2CLCfAhsMAY3Uyqb2lQoh7hB8NnziZEKeYvoI8HiY62k/IkZZwmqB smyz/2JInNAj7sqprQ++dlI+11Q9P2VpJo4WxNyIQa9dZMjH8oGgFC1+VtVdq3NnHu1N OFDC3irg+CDWA0jvsI6bpDiiJLnxgm4pBdNSjSOKYJ0Ktgz8xVout2zQOmpZJQNZYrl6 bPzx3id4Iqi3EGIHRSJenQbAxkyUsQw157wgoPBljeKvfoD0gOKtVBUx1dy+lQ8g7U7p Ee2zFGMjbNAmaXMLy5+/1vku5sRiUz4FSsMohoFv6wCBnTCC9j5s24QYlT2hkkX9v+qC 8zUQ== X-Gm-Message-State: APjAAAUmlX8CcL8PaeRGCfjnz/apuBhnmd7RG945S3DsqnQajsQSOuk6 mR6eajLCC1/hnFpl87C36tn2SA== X-Google-Smtp-Source: APXvYqxy390PGnNKcJWY6ZeOrt/OWzBsNlalabLYYqZk6P/lzvNkeOOZUJO8wkBWZFVHwkCHPoWqOQ== X-Received: by 2002:ae9:e10e:: with SMTP id g14mr24821769qkm.430.1579038980838; Tue, 14 Jan 2020 13:56:20 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([179.56.49.248]) by smtp.gmail.com with ESMTPSA id v2sm7373625qkj.29.2020.01.14.13.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 13:56:20 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id A6E7130081F; Tue, 14 Jan 2020 18:56:17 -0300 (-03) Date: Tue, 14 Jan 2020 18:56:17 -0300 From: Alvaro Herrera To: Michael Paquier Cc: Jobin Augustine , Heikki Linnakangas , Oleksandr Shulgin , pgsql-bugs@lists.postgresql.org Subject: Re: libpq parameter parsing problem Message-ID: <20200114215617.GA18330@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200114085505.GA83028@paquier.xyz> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jan-14, Michael Paquier wrote: > On Tue, Jan 14, 2020 at 12:01:43PM +0530, Jobin Augustine wrote: > > Yes, agree, readability is better with that modification. > > Attaching a modified patch. > > (Please always top-post, this is the style of the PostgreSQL community > mailing lists). The new patch looks good to me, let's see if others > have extra thoughts to share. If not, I'll try to commit it. The thought I had when I first saw this was that it would be better to have a minimal, coherent set of useful examples all together in a subsection called Examples. But then I realized that random examples are already scattered here and there in the libpq page, so while I still think that that would be better, I no longer think it's this patch's responsibility to make it so. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services