Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irYcL-0000XO-Dm for pgsql-bugs@arkaria.postgresql.org; Wed, 15 Jan 2020 02:41:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1irYcH-0006oL-Sz for pgsql-bugs@arkaria.postgresql.org; Wed, 15 Jan 2020 02:41:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1irYcG-0006oE-8p for pgsql-bugs@lists.postgresql.org; Wed, 15 Jan 2020 02:41:09 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irYc6-0003mx-4b for pgsql-bugs@lists.postgresql.org; Wed, 15 Jan 2020 02:41:06 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0ACFE21FE6; Tue, 14 Jan 2020 21:40:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 14 Jan 2020 21:40:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=0nFeeE+H8OSbrWg9A67rzJJ/UW/ 6YtJnqTC/hhU/0Ok=; b=AULsfyOQy1vDLPh8qGWS5MCaI3TWP7XKFpNRMRoC0LO YUWRPzuH+IHa0bfqS06p1SCzlzbojK+rJNuU9fC34kwWA80havkloQNV/V4T4Yxf uoq2VA8sw0LhtpPfEi7wQbWJSD0fp27gqavNy5neMrDxyN792wzRLMXGL9Tac8Cu O193Gu83JSSX4BVW1pESqbpktZO8MCit8JZYzyWB59TzkmiOxBSOXChYIBEyA/2L 5B0UfuaeyalTozN4zu2Gdxfir/2gNxVXvzzo4mcK3LBxtOyAMDmeQ9u9xV8juJYD 8orim7ccgiwBR7ZPobUkwE8mAqo8Jxio5ShIrlb5pCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0nFeeE +H8OSbrWg9A67rzJJ/UW/6YtJnqTC/hhU/0Ok=; b=W2jICf7BfS9b/0hI8nUQcD 7FTZyrT22Rx0cC+jlJp9Y58EKwbDztxbt+7PHnwRWhbMg92VoZSzRPN42/NcFfaL O8mNXTyzkkgvhf4NvxyGUUyG77cb4tVq1D1dhS+onwhv8IpyGEZI6xeBSwNkG0o6 d7iHRElZ355U/5uCdaZNptuBE2+R+QDQ8D2QWHW5R/a5t+GJVfXKA45Gb5PKEmlu NB2m/AfqmiOJWEpNiHWO/D1Qe7W1duzaHCVo+DAjUw6gw+sQPM3yFkKBUYQDjFGJ s45Ct9LgEi5pJwJ15tOsXxZu2eyHSjNIMuGdSNJ2siYYw7SIcYLE9zA8odhRqOuw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrtddvgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 066DC30607B4; Tue, 14 Jan 2020 21:40:47 -0500 (EST) Date: Wed, 15 Jan 2020 11:40:30 +0900 From: Michael Paquier To: "David G. Johnston" Cc: Jobin Augustine , Heikki Linnakangas , Oleksandr Shulgin , PostgreSQL mailing lists Subject: Re: libpq parameter parsing problem Message-ID: <20200115024030.GC2243@paquier.xyz> References: <22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi> <20200109043809.GK2251@paquier.xyz> <20200114060317.GF1515@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DWg365Y4B18r8evw" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --DWg365Y4B18r8evw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 14, 2020 at 06:52:07PM -0700, David G. Johnston wrote: > I would probably choose to move the example for the options parameters to > the "Parameter Key Words" options section: I think that this would be inconsistent with the rest, as that's a URI and all the other examples are there. I agree with the feeling of Alvaro upthread that we could do a better effort with the handling of the examples in this section, but it is quite unclear to me if that would actually bring more clarity to the whole, and that's not really the job of this patch. > Also, regardless of where it is placed having both the username and > database both be named "postgres" in an example just adds unnecessary > mental effort to understanding the example. One that none of the existing > examples do. Name your user "user" and database "mydb" unless, as with the > desire to include a space, there is a meaningful reason not to. Good point. Using "mydb" or "user" instead of "postgres" in the new example would be less confusing. Another question, would be it better to use "5433" instead of "5432" for the port number. That's a nit, but as we are on that stuff let's be right.. -- Michael --DWg365Y4B18r8evw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4ee54ACgkQnvQgOdby QH23Jg//bZAGBsI8mbTy6Do9F14aCiXcUyjHK+5JS+anuLYgl1UaMEMt1/m6Zkry MSN8XqYXR9SeU7SKqUNfFQgUFhfBlpiaUlVbVtlBy/Sh02b8IYtUU5WYGJ+vtUku lFXNQPRiyLdWT6DbPEv3r6T0YDtdfF6Zd7Yyz91rh5zYiRsX4ZuclrH7zg6JApqB tUoiOvYRNugLSY6q0I3TRPu+Z/K+rcEQuMwu1Ia+MYucLkzSjPK8WjwDcfvsK91T Lobli8u7rxQrzFarHo9+dk8v++jOcwl/QSKc4W4CBnhgQbybHQNhT4lMLpKvAKHr V/GuO69fk27wxeL/ZXJt/iehhNJgt0nDfGAF7UQyF0+1mQRz7THqVcjEXNZ/UPJz TRwVcrNQqJdQS2jbmNd4dgwzQYBQH2CmRk/NDTp33dXnp6C8I2NgFRXd7RN85B6Z /O1a+dnasAC5Bf/zyVU2QIkHRVF6APTsuixIczL/BpektORL3Kz4gYP0PzAUjDH1 RjJ6o8wk4oSKC2oEzv2vJPttRgLYdOTorv12xvTmB83sAK4e5weqnGPq+XHZvqHX F8+dyr7gVzfygNpk+QvFsTP2iiwRoewaKgEzQMqes+N3R5IapHIXZdTrmDnmEGs+ HYWm8WZRXdcZtmjZS1v2X2ZDey80Yrp5NnYrL7cFzsnQj/KVcio= =pPmF -----END PGP SIGNATURE----- --DWg365Y4B18r8evw--