Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1isYum-00019H-Ae for pgsql-bugs@arkaria.postgresql.org; Fri, 17 Jan 2020 21:12:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1isYul-0002t5-3J for pgsql-bugs@arkaria.postgresql.org; Fri, 17 Jan 2020 21:12:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1isYuk-0002c5-Jt for pgsql-bugs@lists.postgresql.org; Fri, 17 Jan 2020 21:12:22 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1isYuh-0003qJ-N7 for pgsql-bugs@lists.postgresql.org; Fri, 17 Jan 2020 21:12:21 +0000 Received: by mail-qk1-x742.google.com with SMTP id d71so24153362qkc.0 for ; Fri, 17 Jan 2020 13:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Sq31YsDZhdvGcwAnujUX/+5I1JxVr85GVLFlm8Um1ck=; b=fF3ZYbCvQsXMwDgeP8eUkK80fT7i/uWcWL80NqaEh8K81OnoPluM3V6CxxHIqEoRAz uyCAtH255qIskzsFTiwO4s4s+CY7uE4HV3e+9TZvWb3rw7RNPsKZg6PcK1nxU3hi6er+ jWmIC3l2ezQ5LtgkIX6zhqwgCbAnERwYOC6fm5OPYDZvndoCERv5m9gHnQ4MVctWD3Cj X/MwuwxX9JL8SXVP2h7wLFmjZNFTd18HuULljhtTkHIOO+pS/05ur+a6r666LZ8VMLEC DaLF5XgtQ4gJzLUlD8awo6lndaknwZeyPFhX9T2spquQfzzkhe1TUdvcdR2XEZx7YKZK DLpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Sq31YsDZhdvGcwAnujUX/+5I1JxVr85GVLFlm8Um1ck=; b=JHWOmrV+GHteDNDzYh8YMHeBNmPcQ/C+ZWTqtwFIEodrkLe8VGIaD8Z6K6X8pu1Rgz 3XZswi0Zi8L7mJ0fso5IQl5OuxRIvFZGi+LQlauLxNOfU0taA3/d18qivhoA1aCspgP+ G/gTFBFXu5eRWeH5mhlr6hKlfBf1g/3T9thgA5gl1FgLNT+BiYcxuJqOfkx49a7Jxmgj 6o7oo0UT3TT5UPsHgYE07qx9tdbVLnuWVAuBCIWKWqeDlErBLjIlc3MuqIY1IJRyzhO+ PHpsk+WGKQfhmQhQ+G2FepuYZIHgDEsCwdTDmwV3r9QrTvgEmFSJtHaO54pt4+oBF8PF Wzww== X-Gm-Message-State: APjAAAXNvBFgncjYeDVKYX32OyS59N7UvcPFQV5+sMHlk+c2wUvAwGNY x6teFdB428c9wcpx5k2AR8OTJA== X-Google-Smtp-Source: APXvYqx1cIT5TtWmn8bN4M/Hem8zgX2dlQbMmSHUqKjmdISzPIb8RwEYDTyHTBN/5sRyS9rb+MQKQg== X-Received: by 2002:a37:6704:: with SMTP id b4mr40821035qkc.32.1579295538803; Fri, 17 Jan 2020 13:12:18 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id f23sm12216694qke.104.2020.01.17.13.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 13:12:18 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 575683009FE; Fri, 17 Jan 2020 18:12:16 -0300 (-03) Date: Fri, 17 Jan 2020 18:12:16 -0300 From: Alvaro Herrera To: vignesh C Cc: Dilip Kumar , Amit Kapila , Andres Freund , Tomas Vondra , PostgreSQL mailing lists , PostgreSQL Hackers Subject: Re: Reorderbuffer crash during recovery Message-ID: <20200117211216.GA7044@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jan-17, vignesh C wrote: > Thanks Dilip for reviewing. > I have fixed the comments you have suggested. I ended up rewording that comment completely; I thought the original was not explaining things well enough. I also changed the comment for final_lsn in reorderbuffer.h: not only I remove the line that I added in df9f682c7bf8 (the previous bugfix), but I also remove the line that says "error during decoding", which came in with the very first logical decoding commit (b89e151054a); I couldn't find any evidence that final_lsn is being set on errors of any kind (other than transaction abort, which doesn't seem an "error" in that sense.) Please give these comments a read; maybe I have misunderstood something and my comment is wrong. Pushed now to all branches. Thanks, Vignesh, Amit and Dilip. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services