Date: Mon, 3 Feb 2020 12:40:22 +0100
From: hubert depesz lubaczewski <depesz@depesz.com>
Sender: depesz@depesz.com
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	Hamid Akhtar <hamid.akhtar@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #16171: Potential malformed JSON in explain output
Message-ID: <20200203114022.GA29777@depesz.com>
Reply-To: depesz@depesz.com
References: <16171-b72259ab75505fa2@postgresql.org>
 <495433FC-A268-4956-9B61-5FB135EE5B73@yesql.se>
 <157985813081.742.12901374861257824963.pgcf@coridan.postgresql.org>
 <9342.1580585875@sss.pgh.pa.us>
 <5217695A-8776-4F59-823A-B391DCA1F601@yesql.se>
 <1763.1580662112@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1763.1580662112@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sun, Feb 02, 2020 at 11:48:32AM -0500, Tom Lane wrote:
> > Does that prevent backpatching this, or are we Ok with EXPLAIN text output not
> > being stable across minors?  AFAICT Pg::Explain still works fine with this
> > change, but mileage may vary for other parsers.
> I'm not sure about that either.  It should be a clear win for parsers
> of the non-text formats, because now we're generating valid
> JSON-or-whatever where we were not before.  But it's not too hard to
> imagine that someone's ad-hoc parser of text output would break,
> depending on how much it relies on field order rather than indentation
> to make sense of things.

Change looks reasonable to me.

Interestingly Pg::Explain doesn't handle either current JSON output in
this case (as it's not a valid JSON), nor the new one - but this can be
fixed easily.

Best regards,

depesz