Date: Tue, 4 Feb 2020 18:19:33 -0800
From: Andres Freund <andres@anarazel.de>
To: Vik Fearing <vik@postgresfriends.org>
Cc: andrew@tao11.riddles.org.uk, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16242: convert_tuple_* not handling missing values correctly
Message-ID: <20200205021933.c4wtkpcx2li3um2k@alap3.anarazel.de>
References: <16242-d1c9fca28445966b@postgresql.org>
 <31edb400-f065-73c4-7b1f-2953ad3413e6@postgresfriends.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <31edb400-f065-73c4-7b1f-2953ad3413e6@postgresfriends.org>
Precedence: bulk

On 2020-02-05 03:03:04 +0100, Vik Fearing wrote:
> On 04/02/2020 03:24, PG Bug reporting form wrote:
> > The following example shows a tuple appearing with NULLs in a column
> > declared NOT NULL, because there is a missing default value not being filled
> > in. The cause is that convert_tuples_by_name, or more precisely
> > check_attrmap_match, thinks that it's enough for the tupdescs to match up as
> > regards attnums/names/types, without considering that the source tupdesc
> > might have missing values that the destination does not. So it incorrectly
> > concludes that no conversion is needed, and the missing values become
> > null.
> 
> Here is a quick patch that fixes this on master.

Should include a regression test...

- Andres