Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iza29-0002wL-SN for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Feb 2020 05:49:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iza28-0006ud-O3 for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Feb 2020 05:49:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iza28-0006uW-Fx for pgsql-bugs@lists.postgresql.org; Thu, 06 Feb 2020 05:49:00 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iza21-0008Gd-P8 for pgsql-bugs@lists.postgresql.org; Thu, 06 Feb 2020 05:48:59 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 714BB6D8; Thu, 6 Feb 2020 00:48:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 06 Feb 2020 00:48:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=HIpN7vYgTjeI4a2fYlzz5L8DE7K WnejSvU8wxs4Mt1E=; b=bfAGBwbH7jXgYPxEiwI0+sQD7z2nA6NXg7tSUHxBghZ TyGDa3n5kZFNo524C3/OrtmfilE7V3cibFavaK6gKupvIwAE9oS3Ohu74vKc3MGh 94N6LgY8fOENIattf/9+dZ2fVUCx7ypviZJB19dW7Tz7Rut+Y5VWkHGTrGXnUnQI de+h00aM0CoV831bF4We4cqy/Jnlplr9UngF/TAWkB3Jpo/zIJSUTo020sxmKFvI 0BoEC5jH/zWOL3vuZsMZcxbXib4Xim4z7VXGx9AFWkEYX7SpeyowEHJUzLwnekjV IrAt5jhquuwk+w2zx54SfB9ZWnNoKkcabbEWXCJJm0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HIpN7v YgTjeI4a2fYlzz5L8DE7KWnejSvU8wxs4Mt1E=; b=lKq8ojTvojI1O9k9MLN16x zOkkZSYLLQ3UB33dmGhR9fHnDQSKxh0zZjb7AL+TIEXxvLnbLA3oJRXa7IqG5YQO vKpw8CuFVjKsfAryDpzu7gRtcgZ7YNaOHVTZ379PSfpnKza+RyjLEfKJi2+wzl5T adHz6kxmioaYe6SAkzOpEzAOaUkfFK5TQJ7yBsGn5LuoJ5Kzc5yu9vcK44l5hq34 HXNY/XIO9Ks/3N0pcgwcq8XdzrqTKH8Yv7b0c7MaRxxcUVUFMt8LAJ+K9qXLoS5s LgBEHmBfcGEXnonTzDkF3FDq3YRkQ7aE/1m5w54RPz6eTXzjFngC8weE5WfgU0Ag == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrhedvgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesph grqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 4843D30605C8; Thu, 6 Feb 2020 00:48:49 -0500 (EST) Date: Thu, 6 Feb 2020 14:48:46 +0900 From: Michael Paquier To: Andrew Gierth Cc: Vik Fearing , Andres Freund , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16242: convert_tuple_* not handling missing values correctly Message-ID: <20200206054846.GI23913@paquier.xyz> References: <16242-d1c9fca28445966b@postgresql.org> <31edb400-f065-73c4-7b1f-2953ad3413e6@postgresfriends.org> <20200205021933.c4wtkpcx2li3um2k@alap3.anarazel.de> <3c396c9e-960f-9c03-63b7-d58e0e044fba@postgresfriends.org> <20200205022634.77y7fg7vyhn2svh7@alap3.anarazel.de> <5e0747c0-68af-c937-b8f7-c11b12126d7a@postgresfriends.org> <87zhdwn8le.fsf@news-spur.riddles.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YIleam+9adpUeYf+" Content-Disposition: inline In-Reply-To: <87zhdwn8le.fsf@news-spur.riddles.org.uk> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --YIleam+9adpUeYf+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 05, 2020 at 07:22:20PM +0000, Andrew Gierth wrote: > I'll commit this (with fixed comments) unless anyone can immediately > think of any reason not to... The patch you have written looks right to me on HEAD and the back-branches. Now, you have added only a test that stresses atthasmissing in convert_tuples_by_name_map_if_req(), but you are not covering the paths from convert_tuples_by_position(). Shouldn't we have a second test for that part as well? -- Michael --YIleam+9adpUeYf+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl47qL4ACgkQnvQgOdby QH0qAw/+J5WdclXuNJbPh0Rcx/dYsHAk0oQQlLp/DDfGJmIKjwnNSMxImyHkNfO2 u17qXrl+FlurkySvZYbTWff38PnqPjom80aVGYy9dmBEAcMSUi7KbkMjI5TsSG39 hO8qFDrXIc6l+Qqhg+4HsC94A32CUp1DWg7dGx/gCe+/UzdhwDm/L337252R+Oo+ qcCv0RmutOs2xrBRGaBXmrphqJEpDmp4qwIFK6Xrnp6GePWvOGGeTjizAbKhU5Uw hJFUdJyQMzWK1jRYKakUoSHc7MDvvRLICQ9cK66EmNaObHnsBGeGh2lF1nJzo8mk LSQju2+blF2jSJSHcrcojblQOiXQIIxBi58zhTfM/Vbvk/M5uB+ZOV9W3YgTnHxi lmtbFh08lsMcBlKzo8ylBzOzwnw+JQSeVl2Tdikzwa0HrCPjsN+e+9QFebiNcMi8 J60E+AQr4vV8rH0DiwPRihgZBN9FD7ZZ1Ew/HsXAXtieNQf1znwtiCYIw2GgwBZg /uRurxGlgIIBSpiTahX90qxacC9/cHuNmdP4HSRqfZ4EL6FnizI5nPNx0Zl94+Fn FrJMNeujEkoM0iR+Ab7Roj59nSmmJNkYZIUb9tNKDZkVMjfN9cy9DO89bN490HcD R/lfLYueilyzh6ZuEBSeEv2e9G281OMqD1ZsBeupH5OMAIR3+W8= =IIDs -----END PGP SIGNATURE----- --YIleam+9adpUeYf+--