Date: Wed, 26 Feb 2020 17:06:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16276: Server crash on an invalid attempt to attach a
 partition to an index
Message-ID: <20200226080624.GH17153@paquier.xyz>
References: <16276-5cd1dcc8fb8be7b5@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LiQwW4YX+w4axhAx"
Content-Disposition: inline
In-Reply-To: <16276-5cd1dcc8fb8be7b5@postgresql.org>
Precedence: bulk


--LiQwW4YX+w4axhAx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 25, 2020 at 04:00:01PM +0000, PG Bug reporting form wrote:
> The following query:
> create table idxpart(a int) partition by list (a);
> create index idxpart_idx on idxpart (a);
> create table idxpart1(a int);
> alter table idxpart_idx attach partition idxpart1 for values in (0);
>=20
> leads to a server crash with the following stack trace:
> Core was generated by `postgres: law regression [local] ALTER TABLE      =
  =20

Attempting to attach a table to a partitioned index?  Nice thought.
Without the assertion, RangeVarCallbackForAttachIndex complains that
the relation is not an index, which is right, so I would be tempted to
just remove the culprit assertion.  Any thoughts?
--
Michael

--LiQwW4YX+w4axhAx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5WJwAACgkQnvQgOdby
QH3atg/8CBULb11LVLGg9zQ7rn6B/sqL3TovjspGOEmMyJr246xDdfAxhVwpfm7K
HOFBPu16TTisD/EtFLvKz0B3q46v+BvLizXf99/b85KLJCncvJ+ixH/etakJskkt
AX/VTzqp7ysp9roAoKNxOQwASExtZMCeYc38fz40p7poleMwzrUzMoIcowXBZUJL
sXRbvZUuWjr6Sths8NWvNaI5T9NTbEhoy7/hCZ9A5QkGeF+teiQ43Beyo6HzfQ2a
kSKnrg/xs2YKcmz4BYV1c1DqD0ouZElDFw+CKgiC8YDI5WYE0zNMHDz3Jcxuc4xS
aSZ3MDPuMlrnngBO3iLrYblBAWaft/t8EAlx7jKmfsbxoKfZSvCc2BAA4TFzBaa9
mi/r4elh8LfIAEPtDIhmYoaSNBnUWnpVFpHHuTG7kZjcJ3xGH0/3fQxE9r55Pufa
Z8FMEf2wqnVCSYc6Tsc/GDPCC+xYLLcHfHEl7jn5ZEhx2j2pes3tsz7LUkb2YjSf
h6eqZWY5fLHsdoyAJHIdRPI27zSIFuEtl3IPwYa2pxLRqFh9y88CE6DHFIfi27xx
QPH/Uu2Hv7w+HQQ3QLNJacee2Tt0/mB2bFlm9++UNm3V4VQoSX5UCmJnew1qKZfm
0Db2swTRZqkB/hLqT2nVAmJonYNa8KCw8Y9qDVZFzC94oyHAtqA=
=M3Gg
-----END PGP SIGNATURE-----

--LiQwW4YX+w4axhAx--