Date: Thu, 27 Feb 2020 11:31:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16276: Server crash on an invalid attempt to attach a
 partition to an index
Message-ID: <20200227023120.GC1969@paquier.xyz>
References: <16276-5cd1dcc8fb8be7b5@postgresql.org>
 <20200226080624.GH17153@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX"
Content-Disposition: inline
In-Reply-To: <20200226080624.GH17153@paquier.xyz>
Precedence: bulk


--+xNpyl7Qekk2NvDX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 26, 2020 at 05:06:24PM +0900, Michael Paquier wrote:
> Attempting to attach a table to a partitioned index?  Nice thought.
> Without the assertion, RangeVarCallbackForAttachIndex complains that
> the relation is not an index, which is right, so I would be tempted to
> just remove the culprit assertion.  Any thoughts?

FWIW, one can note that ALTER TABLE ATTACH PARTITION with indexes
correctly registers partition indexes without partition bounds in
pg_class, even if the grammar cannot accept ALTER TABLE without any
bounds defined:
create table idxpart(a int) partition by list (a);
create table idxpart1 partition of idxpart for values in (1);
create index idxpart_idx on only idxpart(a);
create index idxpart1_idx on only idxpart1(a);
alter table idxpart_idx attach partition idxpart1_idx for values in (0);

So I would rather not issue an error in that case on compatibility
ground.
--
Michael

--+xNpyl7Qekk2NvDX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5XKfgACgkQnvQgOdby
QH2ZgA//S2PErOC6Jm1uHNg3uZzc8PKrG/cQI6cvybLXmWk2DeC//5Cpq9CloUGr
88gLdCIUYb2YguKstK5v1WMDXpeofEM3wqkxHWOnej17jMGtXU/mJCJVJcTDm0D4
fraly3hzx/1dLexj/k256XThUZ2XdrJXu6lFrW6IsOna3UIif2jS5txWOyqysnlq
BHe3Bq9gCB+yWRG5ayf8qPhA5I8eN6q0aqbRU8SZKqSg8sUyD0Bghgr3HIVDAYLN
fHpFwtYMfcY0sASvRdVmxEbUyRSMUH4IxHGWBL9Mt3ELhbJpAPbvieCY5RFGT1cV
krRY6pKyjc9TSc3dgT4ScT9tUkF+FxQD6cVL7THWttam2LZ76/I18h7JvRqSOjUM
fQ68viAtIn7hLYwpVZmTARI0NmHVM0U9G2Pj3cju+H0bdu5RZD/SiV1GvrNCIvlA
pRIz3LQFex4QAhPsvK0MWW+iLqzvHliflvFYdsGcm+4W+TOnGaWNMgUIvHkC/ApG
XKHFxxdO0V9Knqi8AFzabJZC2ftC0c2eLVaEOI5bCctz74HBaDSq0ZwYhi65DpVV
jKUeXbeQs3oZTJp8VblwhR6nwucbP+yryd6ueta5YH7NmYe4L56S1j3DuH42R3iq
T6j+3LtFSTDu2arlfNXCe6VBW5zH0h6VFAF1QbIpJt7EWg6WmyA=
=HQj/
-----END PGP SIGNATURE-----

--+xNpyl7Qekk2NvDX--