Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j7ox7-0008Rp-CD for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Feb 2020 23:21:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j7ox6-00045J-8l for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Feb 2020 23:21:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j7ox4-00041X-7P for pgsql-hackers@lists.postgresql.org; Fri, 28 Feb 2020 23:21:51 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7ox0-0000DB-ML for pgsql-hackers@lists.postgresql.org; Fri, 28 Feb 2020 23:21:48 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id ACCD8C66; Fri, 28 Feb 2020 18:21:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 28 Feb 2020 18:21:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=G2kg6zZcLPxoyQkwrrPiWkkwgP9 4QkQ/ixNyr/lW8GU=; b=l4ucZJEijuhph0FFT01+Tb490yyoJJF8s9adqL9klL8 QexmNkJR0heoOwq/S2CRDncpkJ0jsJHCSwl6rEJZAWU82K54Zzj+qv+9XJXhPrIm mLCxPwWLYZCQCLKbLKcvbNRamzfmhs22fthHd58ZatUfo/ktRmjo0tbbc6WMDcFV S9FllBW/0B2Nj2lq2QzyHc3Rpe09eVa8tph50Agd/hYCKReH6qX1v3lszfccX4LI LdN/9ZHOMTgkIv2Q7iRmW+TXIsOjjHc84xm+S6AiyEWvdRZjVXinuWdWVGVkPJAz DiUm+1fqMny1M1fKo2arCDtrbXcPYg0fUNOUEshsbLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=G2kg6z ZcLPxoyQkwrrPiWkkwgP94QkQ/ixNyr/lW8GU=; b=gfsxlXDeU+sIgM28EZYcSK DJ9UqDmuwas5v3OmmmkAUvNE2lgTtZlZxuKFtfJQfxw9QRLhKQ5ohLpYCACqi0Np aJ0DZoAT+DnrhySH5bVN1ntwqyGX/2A6hSezzEB70quqiGMupvfBCkMspCgLqr5g atbiEIQti9QXILyVLgx+ApqLPUCTNZ5zxrnu8Cabh+ika3vNi0Sb47KPhdIW6QrL G/xByVSrGrsqJ/wKS2/LUQlVwdh97JBiSdyYpIlrFrzLZX8DeBQe2wGkwWkzNfZs 7Im9PjiI7aXO0dCCtGDg60LnKYiMtpG+yP5QgT/COhG254kCR5Ptj3sR3K5k+lkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleelgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesph grqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 175D03060FD3; Fri, 28 Feb 2020 18:21:40 -0500 (EST) Date: Sat, 29 Feb 2020 08:21:38 +0900 From: Michael Paquier To: Tom Lane Cc: Mahendra Singh Thalor , Robert Haas , Kyotaro Horiguchi , PostgreSQL Hackers Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema Message-ID: <20200228232138.GI2688@paquier.xyz> References: <20200108004409.GA3413@paquier.xyz> <5602.1578444917@sss.pgh.pa.us> <20200108015601.GB3413@paquier.xyz> <20200109040612.GG2251@paquier.xyz> <20200110080125.GA250447@paquier.xyz> <20200110110748.GD250447@paquier.xyz> <20200116040618.GF3117@paquier.xyz> <18998.1582910402@sss.pgh.pa.us> <4172.1582915529@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/GPgYEyhnw15BExa" Content-Disposition: inline In-Reply-To: <4172.1582915529@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --/GPgYEyhnw15BExa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 28, 2020 at 01:45:29PM -0500, Tom Lane wrote: > After poking around, I see there aren't any other callers. But I think > that the cause of this bug is clearly failure to think carefully about > the different cases that isTempNamespaceInUse is recognizing, so that > the right way to fix it is more like the attached. Good idea, thanks. Your suggestion looks good to me. > In the back branches, we could leave isTempNamespaceInUse() in place > but unused, just in case somebody is calling it. I kind of doubt that > anyone is, given the small usage in core, but maybe. I doubt that there are any external callers, but I'd rather leave the past API in place on back-branches. -- Michael --/GPgYEyhnw15BExa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5ZoIEACgkQnvQgOdby QH3HUw//ZVEpFryxjz9abT8QTShyQWpC3VRPbntxftqL/SloepYYmKU1/XVmy04r SRXujhs5YlsjoYC6pfSdBW2ur5S+gFiTytbBCVhuMWxX5Es8ZXtY1cdLjbDer3KZ u2SH6U9dkGJYNoZrkH7UKHN1oRwkcpJ135R5WHJs+hq/f0jCGRefwvUtwWA7Hd2U 9VbSfLeyngORRMmnlnXhOtrnTcToJNPpd+m9vq9FcEzUiEncEV50nMknH0QnXDGn rXh5fkbjCywlSBYcH6Ti/gqBA1oG2fRSekLiRcq0PeXs5RfhLWYnyqStTsDST58m PLiC377QOXp2L/j+qQu7nCyeeeZIVgCVoOsVTSXf0P8TDEixHMDeqavq3ewzUtIF M0V1tkFq5s3ILeMIUZ1QJrMHbIhE6iESTo4kf8HuLig6uVoj9zTcvHWLjsW+9oy4 GUvp2BLvQCGqUZVClJdqQ+gIyqVW6YCmx935SbclB1MGoIudlxe6LXsQcBzM61wi LVNkxb5sap7ywQTmashuyQ421ryf3P6cXE0P07bDwTlMP9sa7QH2q60WyQG8df+i Jqlco1070iovkt7gdQE1IsvKPBBz9L69F7N/Hp1EQm7NDfN6sycXAwolDGJvpTqq 4dknYILeoKzFRofMvWv3JV9+uixSWfHmdQORcuaEt465jf4EdgM= =MBTn -----END PGP SIGNATURE----- --/GPgYEyhnw15BExa--