Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j8bvd-0006p0-OK for pgsql-bugs@arkaria.postgresql.org; Mon, 02 Mar 2020 03:39:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j8bvc-00017I-EM for pgsql-bugs@arkaria.postgresql.org; Mon, 02 Mar 2020 03:39:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j8bvc-00017A-2S for pgsql-bugs@lists.postgresql.org; Mon, 02 Mar 2020 03:39:36 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8bvU-0000yv-SN for pgsql-bugs@lists.postgresql.org; Mon, 02 Mar 2020 03:39:34 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A278A21AD0; Sun, 1 Mar 2020 22:39:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 Mar 2020 22:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=Kkeg/FxL7JFbz6jc1KwSmKjdipx Tai3QqKYMbSXrFCs=; b=N5DaIlkA35CqRrdUChxv6lfJdU1bDs6zgMP5P1jFvXo GXvScbg2HL+W/R596ndFUzlFFZ0s2K/Nm0GrWn42DTc8lp1mDD+E2TT0JNl7Nnu5 +PPagwEiEegnLiggn6IIXsXXlKPZIJ5PXUxI2ci2TdKA1hM8KvUTCl2SrG4bRI5v TT3zOwxOqxfipTkiy916XSxSg3/u727y8zmItAJQx6tFuK2w/ABQG5n4PHJ/STY1 Suj/1i0j1d8ioUDGB/PAUWxaj+HDYY4ynukt8rlrcz4UyAekiXdONqc68qKIfXuw BaQbMnzLiCKkTkUnSEb6tSlQJP3UDv11mm5kDNHZB2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Kkeg/F xL7JFbz6jc1KwSmKjdipxTai3QqKYMbSXrFCs=; b=g/xHjCQVC+wYq29CG4RSQ4 q5WshXdhPLd1gaVyQ1MY0gtiUdnhadmznA3gdODLGIfrIeuhLCkJNAiFdqWJqWEk WUJZaxe6lcimxGnJo/Wr7ym29R66o+aOXfzkWBS9prcKP3ZOJOSnpBZ/JVShaeW2 HM01AexTTAglkX8XVgliW1TwJnkfp4KZxJH1mGNCXPzD+3lVwQYa3AhKPvwQ2SHB H1wfjsgu3m0HG6EUj2wmX15eYBiPYirliT/AGBuhq7XP2GCMBgONMlmZbATPqKY5 ABbR+vHvlHJhqE50PQ12K5n1ENafWLpK7oJHCqMYemxMnE4yl8r8XB+6OjtW64eg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddtfedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepuddukedrvdeguddrvdegledrjeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprg hquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (mp76f1f907.ap.nuro.jp [118.241.249.7]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D5153060BD1; Sun, 1 Mar 2020 22:39:24 -0500 (EST) Date: Mon, 2 Mar 2020 12:39:21 +0900 From: Michael Paquier To: Amit Langote Cc: exclusion@gmail.com, PostgreSQL mailing lists , Alvaro Herrera Subject: Re: BUG #16276: Server crash on an invalid attempt to attach a partition to an index Message-ID: <20200302033921.GC32059@paquier.xyz> References: <16276-5cd1dcc8fb8be7b5@postgresql.org> <20200226080624.GH17153@paquier.xyz> <20200227023120.GC1969@paquier.xyz> <20200227124952.GC403330@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WfZ7S8PLGjBY9Voh" Content-Disposition: inline In-Reply-To: <20200227124952.GC403330@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --WfZ7S8PLGjBY9Voh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 27, 2020 at 09:49:52PM +0900, Michael Paquier wrote: > Yeah, I have been considering this option, still I am hesitating about > what to do on HEAD. My own take would be to fix this issue on all > branches by removing the assertion, but I think that we should wait > first a couple of days to see if Alvaro can comment on this issue. Okay, after sleeping on it for a couple of days, let's block the case on HEAD and remove the assertion in the back branches. Could you add a test case in indexing.sql for the patch of HEAD? -- Michael --WfZ7S8PLGjBY9Voh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5cf+kACgkQnvQgOdby QH0a5xAAhs8nJcV2VREbNxtNfO9p28ep832ZwDM3iP7WEU7ZkG4hluMah3RGqzV2 rUnmV0BT07UwCthabadv35/9/lQYDCq5gK4biW0kCCtvv3N/SGsYGD1RH6Q5g3p3 CZTSXMhqh0nPozhddztPHd5JDPfriGcLp/mG/wo8JpWfalrSK2NbGlNzUu/H3vLW wQjKsd2GB2hBpRlv2YfSrdX5uNsKl5tAM59obExCpqpMVbtn14eCoW+DCpWBVxqE d0a6KCQjILfcobekwZtKUbS5916znoj0JrZVfAe+UyTrcb9sT+EitZ2J+rN72Ce1 AVt8bxRTXU1dAgjBkZYz4m3XSGB0iNdNxDw0niUB0GOR+uX1TW2+zFY5UkHViIL0 VKixwzLdH0deCIb8JZwOH+KBsZdEg/3oZr+Ws5Wgal/G55omDHFGW0eoXBrSaGgI WtML7MoBvaeeNKWr3QN5xWnpoJqR8EeJQfpVo2XpLAJaJ9s+3rLmbvjtY2QqdkS4 G9yainQ3zSXyjZY7tooLe3SDF9GM6C7gaDe9mzycxR3Sfo1PBmrge/Zx80YHCz97 thzzm5HiQ04lLyTZlbZVgZf7Z7CblkhFcqwdiJayW/Km9lRcWBlx+tBC1uJpfU5O k4Dbl5dlXJTN86NMtzYhckvBq6fVIj2mtH3QASuVJVqUYFcwK0Y= =LHoL -----END PGP SIGNATURE----- --WfZ7S8PLGjBY9Voh--