Date: Tue, 3 Mar 2020 14:01:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <amitlangote09@gmail.com>
Cc: exclusion@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: BUG #16276: Server crash on an invalid attempt to attach a
 partition to an index
Message-ID: <20200303050122.GG32059@paquier.xyz>
References: <16276-5cd1dcc8fb8be7b5@postgresql.org>
 <20200226080624.GH17153@paquier.xyz>
 <20200227023120.GC1969@paquier.xyz>
 <CA+HiwqFziODja7kVzp5M7t2XfnUT-nxxqEse5eQ2PR4Z0JpLvQ@mail.gmail.com>
 <20200227124952.GC403330@paquier.xyz>
 <20200302033921.GC32059@paquier.xyz>
 <CA+HiwqFQHAN9ewYWn_sDLGyusv0Q-1FGnRQFGmXt8HNcAEPmsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oOB74oR0WcNeq9Zb"
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqFQHAN9ewYWn_sDLGyusv0Q-1FGnRQFGmXt8HNcAEPmsQ@mail.gmail.com>
Precedence: bulk


--oOB74oR0WcNeq9Zb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 02, 2020 at 07:39:44PM +0900, Amit Langote wrote:
> Done, please see attached.

Thanks.  There are actually some safeguards in ATPrepCmd()@tablecmds.c
when calling ATSimplePermissions().  However, as this is checked for
both (ATT_TABLE | ATT_PARTITIONED_INDEX) then it would not blow up as
ALTER INDEX and ALTER TABLE use the same code path.  Using DETACH
partition triggers this code path's error though, making the hint
added in your patch actually correct.

So, applied this stuff down to 11, with test cases on all branches.  I
have added a test case with ALTER TABLE DETACH PARTITION for an index
while on it.  As the error is triggered at transformation time which
is a tad more generic than the work done in tablecmds.c for each
command, I have also removed the error hint and kept the code
simpler.
--
Michael

--oOB74oR0WcNeq9Zb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5d5KIACgkQnvQgOdby
QH203Q/8DoJ7pqf1hfgx7Dm0HuIGOGu7nzr0FqXREltu4RcO23XhXgBso8NyjnRW
rUxu9t1q9Gk3QFK5GfE6KcaW+/PdTD2Jh/gvKNyEQVJQ3SDlquD+iJhRnKb2Q3xA
yrxmXz7onMO2a76TSTyX4lGzA9iuO23QiR4nSYaF9iYgmUJj2zaiWxoCw6X5i5MX
8uj3g+Wq0QdZ6Y7nFMiq+r0boiJkjRpDx99Fkab4fSdLJ28xBegvSWbYFomVb1ii
bZRnWGTQcDcn18JimA3RAFtupKS8CEL97pzZ9euoFvGFfaSWQX9SeqzSTp7Ia2dQ
rD5mzN+CvY7h4daxZyZBTycHtQRdFQzhfP1WZ2mylpwjaXn2AeDY64CjuhEolpBR
qTpjBvuZDGyyQ8sBLqVz5Ia2wGE3i2IU7NQUnlqiwXFCw/8dYwllLHwKwSOoWBap
LRel6SbRpHn5dnK+PoBxFbpALfd57KzhX2cVWFxVhNhb3OfV5wdq8i8yqXohDMy8
RMhwgKE6P8E76lIJ5nicIGtnOixosoSdb6pyLp6SLIn2PZNIa+pI8t79V++NuezN
KhcPhV3GVHoF2R1bJQZx9GNUCsMbUZnFM2V4kMoKQUsak0D/MyByB4jdJNBxxPXf
bqO8lzwaGO8IshQwnCTVx7y03zAr45Rk3KuCNTklQ3SoZWSworI=
=Y5SK
-----END PGP SIGNATURE-----

--oOB74oR0WcNeq9Zb--