Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jHwD5-0006KT-48 for pgsql-bugs@arkaria.postgresql.org; Fri, 27 Mar 2020 21:08:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jHwD3-0003fe-TL for pgsql-bugs@arkaria.postgresql.org; Fri, 27 Mar 2020 21:08:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jHwD3-0003fX-He for pgsql-bugs@lists.postgresql.org; Fri, 27 Mar 2020 21:08:09 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jHwD0-0001Hh-U4 for pgsql-bugs@lists.postgresql.org; Fri, 27 Mar 2020 21:08:08 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id B03C25F798; Fri, 27 Mar 2020 17:08:09 -0400 (EDT) Date: Fri, 27 Mar 2020 17:08:09 -0400 From: Stephen Frost To: Tom Lane Cc: brahmbhattkinjal18@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16320: GSSAPI Error Message-ID: <20200327210809.GK13712@tamriel.snowman.net> References: <16320-912ad260120988a2@postgresql.org> <20200327163051.GE13712@tamriel.snowman.net> <20458.1585336517@sss.pgh.pa.us> <20200327195705.GH13712@tamriel.snowman.net> <23962.1585341372@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="08mGw3CZk5wypUJm" Content-Disposition: inline In-Reply-To: <23962.1585341372@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --08mGw3CZk5wypUJm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > >> Should we document somewhere that we consider that unsupported? > >> Trying it here, I see a bunch of "deprecation" warnings during > >> the build, but it does build --- which might lead people to expect > >> that it'd work. >=20 > > There had been discussion on another thread about trying to figure out a > > way to detect the OSX GSSAPI library and refuse to build with GSSAPI > > support when that's what we'd be building against. I didn't see anyone > > post a patch though and I haven't got an OSX box to play with myself > > easily at hand. >=20 > Just poking around, it looks like something along this line would work: >=20 > #ifdef GSSKRB_APPLE_DEPRECATED > #error "Postgres doesn't work with the macOS GSSAPI library, please use X= XX instead." > #endif >=20 > (in any suitable spot after #including gssapi.h) >=20 > Now, this is testing the *headers* not the actual *library*, which in > some sense is not the right thing. But it's probably close enough for > the purpose. Sounds good to me. Thanks, Stephen --08mGw3CZk5wypUJm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJefms5AAoJEO1sijiDR2RVlVEP/RJINtIzykiIKfwE1UBrmkg+ No/GYmpWTJNsdpd6vV327K4tybu2ZN3skcBv0RU6PGrWNDGQyr1gRBEQ5EbXv5CO VW9x7Y+7euCYeW09mOGa0gV4rEyK8AtMj7UnB9RVvYxpbUwmYO54hStKwfYePgh8 R6rotTxHFc3F40cS8DTsCz3rRhd+Xeai8EGO0P42JvDxeQ0TvTvFPRNp5+hWcpSF blV+kPHkVnAS/VPxHsZRVOq52eU6DJM8WURg42IOmUypiRQOhHGLrjX5ZlBLCLVE H1O3XVog5Wh1vi1GQJGGUAqgFRSVgbRNIq6AEaLzbXSAuDy2AWa/shET+81QMC7e RbvcrOfFtF6jm7LmP2HecsAdSN+d5V0XjP+naz5HI+sr54tSnJV6h7Mq+cYp10sJ Jbd4x6Rw8ALflrIZJuIlxT6+t8nhLygpGnaZ3PtFmf/amHcfIVfRzQ+jf7pwZMBe N0j6zHrsq97uAGDAwJ7X5aeO6afW+leO1pYOdZ9pOL2Bnft1wNa9E+4BK5SP+PGy gYmwPY1AFdtWnZuDEGUhIqvEm84x4hTCXTxN/TUellJ3Sztv9nnY8AmQL0x22VVo KpHUomhru49/Mqi/w9AiMMxWc7pCBBgOTNJjqjoof0in151kGwWC5w0a6Oy3Hnmi 3aPz4XWfhBovFf6FfOa0 =6Hxf -----END PGP SIGNATURE----- --08mGw3CZk5wypUJm--