Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLjQX-0004AZ-F5 for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 08:17:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jLjQW-0000ku-BB for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 08:17:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLjQW-0000ju-4i; Tue, 07 Apr 2020 08:17:44 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLjQP-00017w-PL; Tue, 07 Apr 2020 08:17:43 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2A12D5C020C; Tue, 7 Apr 2020 04:17:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 07 Apr 2020 04:17:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=6bxk3ghgIOrU4Pjn1JjmhSVl4ZE SHlhWpyTUWANhHEU=; b=G88A1sZGuCXpoWNmLyDcMnbSAUynMH6gTFp884VlNGK CDjdex8ELz0VEIoLeBNLSS80yMSTORXf1e08OJ5MnssCAGFbCVG4GWPlLBYK64La JZ6kr2s+BVqwgnhOy5RNz/f9JwKRQbm+Fg5/v2+Z7qMKzwUqf51UKHY6CCjtw47j vuVtXumpu/2tYyXiukuVDwDTKrtXsIFDS9tS0i9BK5Aq6c3XBYwbLJxWNsZ3SMb1 gk5V3i5h+0lgjn3i15R9g2bzc9j4XC7gaMrYhrsGUwl2mGuG/4EADhM7VDQHuPnS jY9LkQG2+y6fR0ToPLRZrBcsoa8sE1h3WZVG0fQpJYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6bxk3g hgIOrU4Pjn1JjmhSVl4ZESHlhWpyTUWANhHEU=; b=Cr3WKA0sOBFmXmu1iYaB9m 8NPYHnxmlrKglcw1T1NCxVYU7qnHc0aQD7LPLIACteRZxI9UaqJtrmKG70VXdaWt aWchNVtjEOM8v/ETuin3QZQlFuN/1T3NIaP6y1+fm8LC4cZ20ac5L5m/JRFODknH HvgtOHlC8c/qmAqbfPqQG8aRlLP//d//8q+cyU4B/ct6nSIF0BjCUxBA7N58g8QA y7o0jn26e8DqhdumUJ8dwlYtkMD2O9+DWWaxwec4GDH1hN0cp2LaT2xEghoP+wwk 5Xjyl6ztMNYL2P2fclZyuqqNwgA2wiau/lZeBsqnthh4baifAEj41qm1MAwVnvCQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesph grqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id E8A3E3280060; Tue, 7 Apr 2020 04:17:34 -0400 (EDT) Date: Tue, 7 Apr 2020 17:17:32 +0900 From: Michael Paquier To: Fujii Masao Cc: David Steele , Pavel Suderevsky , Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org Subject: Re: Don't try fetching future segment of a TLI. Message-ID: <20200407081732.GC6655@paquier.xyz> References: <16159-f5a34a3a04dc67e0@postgresql.org> <20191212.124856.202839248708529678.horikyota.ntt@gmail.com> <20200129.120222.1476610231001551715.horikyota.ntt@gmail.com> <8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net> <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bjuZg6miEcdLYP6q" Content-Disposition: inline In-Reply-To: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --bjuZg6miEcdLYP6q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 07, 2020 at 12:15:00PM +0900, Fujii Masao wrote: > I understood the situation and am fine to back-patch that. But I'm not sure > if it's fair to do that. Maybe we need to hear more opinions about this? > OTOH, feature freeze for v13 is today, so what about committing the patch > in v13 at first, and then doing the back-patch after hearing opinions and > receiving many +1? I have not looked at the patch so I cannot say much about it, but it is annoying to fetch segments you are not going to need anyway if you target recovery with a timeline older than the segments fetched and this has a cost when you pay for the bandwidth of your environment with only one archive location. So a backpatch sounds like a good thing to do even if recovery is not broken per-se, only slower. Designing a TAP test for that is tricky, but you could look at the logs of the backend to make sure that only the wanted segments are fetched with a central archived solution and multiple timelines involved. And costly it is. -- Michael --bjuZg6miEcdLYP6q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6MNxwACgkQnvQgOdby QH37Rw//eYtEoHbrc3IIaDQ4Wp/8BHTn6na4slhpRrd1DCP8L1cTsykPBOLw3yFw fH8kV5ud6WL9x24QenYpY0mVF8Z6wv71yLhLHM8h6jBxkro0sQ8p/8wq7A/ZlSEd BATS/M26ZE2rpkQ6bBJMui6T2Vc3p1rQnC3R6+KxZ1nx0GGhqPzUb2/4qg6QswC2 +54ceU4OGXex8vcjTXIvFpeg1XvUN80DsTshQyzcNWN00yNKwKtbrSID6yU1rkW8 5TyQCXqrNCL2iGwiGbFB2HBS+uV2n1hEspgCdlBaUP5EvIU/eI9KDBg3p03SHnyX vmbUfeFU0O3bCYhUJIs1NU4yAdor3LrWWMlPx27SqOG26+OEj50+So53WNKQpA/D ZPS0nkGi3xGivb0sCK89rURihr08739DeKdQdvY8ax+qhYW0gImpoXPcrU+3zAci rghDKmvn5ULyJmKtSleiMJBmO4TrFSuIIKBeQYWCrsgIdlOXfkv2QPk+maARnChY 3CKr0dlNJfGv0Z7jnEYeTwzczh4NnR61s+PdKO5soPcN30ze2EL0pmKAPYaI3K36 sSkuz/Y/9rCXeK8RbYabAMbMQFSPxHBknzYeXTq/mYsxZYefSIqB8olFlnvvPJYI UpzWqVy3SZYUkbLLBDd5q9nqOI4UjRyzbj22hl1PUANm2UMQr+M= =MJrA -----END PGP SIGNATURE----- --bjuZg6miEcdLYP6q--