Date: Wed, 8 Apr 2020 11:23:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Message-ID: <20200408022345.GC1606@paquier.xyz>
References: <20200402.130443.1791362864704140391.horikyota.ntt@gmail.com>
 <20200402.130734.613319908534820379.horikyota.ntt@gmail.com>
 <03900fc5-fff4-109a-fe69-83de2c167929@oss.nttdata.com>
 <20200402.162323.770257425358491539.horikyota.ntt@gmail.com>
 <ca964b3a-61a0-902e-c7b3-3abbc01a921f@oss.nttdata.com>
 <20200402154915.4984cff2@firost>
 <3d543ef2-ae02-5e59-3bfe-b79d00dab360@oss.nttdata.com>
 <20200403182625.0fccc6fd@firost>
 <4d48dbdb-e1db-a2d6-2fb2-c2a66efa7818@oss.nttdata.com>
 <20200407171736.61906608@firost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Md/poaVZ8hnGTzuv"
Content-Disposition: inline
In-Reply-To: <20200407171736.61906608@firost>
Precedence: bulk


--Md/poaVZ8hnGTzuv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 07, 2020 at 05:17:36PM +0200, Jehan-Guillaume de Rorthais wrote:
> I'm not sure who would need this information before the WAL machinery is =
up,
> but is it safe enough in your opinion for futur usage of GetRecoveryState=
()? Do
> you think this information might be useful before the WAL machinery is se=
t?
> Current "user" (eg. restoreTwoPhaseData()) only need to know if we are in
> recovery, whatever the reason.

(I had this thread marked as something to look at, but could not.
Sorry for the delay).

>  src/test/recovery/t/011_crash_recovery.pl | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>=20
> diff --git a/src/test/recovery/t/011_crash_recovery.pl b/src/test/recover=
y/t/011_crash_recovery.pl
> index ca6e92b50d..ce2e899891 100644
> --- a/src/test/recovery/t/011_crash_recovery.pl
> +++ b/src/test/recovery/t/011_crash_recovery.pl
> @@ -15,11 +15,17 @@ if ($Config{osname} eq 'MSWin32')

May I ask why this new test is added to 011_crash_recovery.pl which is
aimed at testing crash and redo, while we have 002_archiving.pl that
is dedicated to archiving in a more general manner?
--
Michael

--Md/poaVZ8hnGTzuv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6NNbEACgkQnvQgOdby
QH1dEBAAmnEYqCJ1rOYXukpfdw+aKAysVkpPvi8KOK07QFg2tSttgrvYgMB13HZE
xSZT8G8ArbS7DcWd6wNpETOg08HTPcz73j3nB56G+KhNNeSUsIFLClTH94Dh6PxW
cRsaEF9Q362oSFgOAJKUQ/wHhnRyEI6+H1fg5JV51wj+Q3yt0vFLWaiZJ/P7IiGV
XIAGbiIRopsuTAwqsVjb7nRG3LcL8I+pQ6Iw+ARnd/AqTHpXvIZ0UTZ/uzxxwEfo
OzX4+UrRYbr/x55X7kheaCgzgDHMTcxKWYoQv/hzb5sqoqv8XtWL9NE7DALWN26P
L9OErOYZEBDcSqTKW3qVz2tkd7jiAVUTMI7lpNF5UJaaEHFmEXx8Ex7UsyTND66K
N8USG33sHNHudMRORRqMSwO5sZnmwYvAv5lgjm8Qm4eJND7Ps22CTC1GjqSxeejP
NlxlAFtEHPfsBkOvy6LGH343e9Upbto9mF6ADfAkeGznXvUE/tIR93ANSSCPWG8i
ak5WSWvTd6tRh/xMW0wKsHClwic/QYWd2l8RdWjLVW4BenWGMRMhg33BaRlFzDlR
BMYoO1tbv7O4L2NchYO2gvEQAh7cqQb143hyCaWu1z75pU3uoHAODFBVc3vUhMG2
bcuM0/4Ct/XcHFWUb9a3m9PWP6sVeuhzSlb1T9nqcUPRz5Sv0Aw=
=T7IS
-----END PGP SIGNATURE-----

--Md/poaVZ8hnGTzuv--