Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOx7D-00057u-SS for pgsql-bugs@arkaria.postgresql.org; Thu, 16 Apr 2020 05:31:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jOx7C-0002PT-J4 for pgsql-bugs@arkaria.postgresql.org; Thu, 16 Apr 2020 05:31:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOx7C-0002PL-Ce for pgsql-bugs@lists.postgresql.org; Thu, 16 Apr 2020 05:31:06 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOx75-00026s-LU for pgsql-bugs@lists.postgresql.org; Thu, 16 Apr 2020 05:31:06 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1F9555C02A2; Thu, 16 Apr 2020 01:30:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 16 Apr 2020 01:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=3CN9BA5dzTSAi+XnmateBVoDUQx A3SEgPF+4b9MOGWk=; b=b8x+Yk8Z15D4gUb7J4e8BPdtp48hSBh9CYn39Sg0wiw uPxU9QPEmm8DYAethlUE8xMHD7nC0ITLgldkbd8o+Xm0swrkQnMEq7pSbYO15xxQ 71jrBmkevVcK+vny1/EQfHCV7rfmzV83D1OtIPTKo8vmkaldN/avdNXdfuVMEfhy SWul8R5szHut5FSTLxE5s56eEfW1xGoqPkpPsoEoFyUTqU3Crig8AdO1QVuIQ8pv NUp1TtGfBDBpo1qmRxGKR2KnhsNaMP9kJKrAtTRQjrHFafkz0zIq9dlCA1v+YlTb yCl7AjpZn1Gz/ZKlH0N8CCpLfPvta6lYSiImSq+C2ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3CN9BA 5dzTSAi+XnmateBVoDUQxA3SEgPF+4b9MOGWk=; b=Id46i4eTc5NZCiw25BnyPc 7i0Q8cHDIr/YwYfkrOEffr6gtqe6xuXHVLEbuHWzPLBmEY+3Xjd/JMsmnYzMgUfl QjbHOmqdNeYDhcYVnMDA9CXboSKQdlRaz7fYIyeO6BgVtbq+PBJoXkTaa+6tiCmm Svpehr+Rc9BtlxriU15jO4dYQQVa1uvcC49hvxW0OpHJsnjqnJ8dX6ETevTmlqds Ltwprau3Dn1ouXcpDaYPoYy9t9Dbt2YE0sl3dp4OeIngVfKROTyvt9ixUU4t3SCq F3hLY7e3Sdw4ZADWgEU5GoYsUHY18T20cnKVirtCypzOK3FcQ+QPXCBWKKWoqIbw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeeggdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdefhedmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecukfhppeduuddurddutd dvrddukedtrddukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 87C1A306005E; Thu, 16 Apr 2020 01:30:50 -0400 (EDT) Date: Thu, 16 Apr 2020 14:30:36 +0900 From: Michael Paquier To: David Rowley Cc: Tom Lane , cameron.ezell@clearcapital.com, pgsql-bugs@lists.postgresql.org, peter.eisentraut@2ndquadrant.com Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns Message-ID: <20200416053036.GA81957@paquier.xyz> References: <16369-5845a6f1bef59884@postgresql.org> <1047.1586994741@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 16, 2020 at 12:40:24PM +1200, David Rowley wrote: > On Thu, 16 Apr 2020 at 11:52, Tom Lane wrote: >> That looks like it'll fail on a null result. >=20 > Thanks. I'll have another go then. Shouldn't you have more regression test cases here? I guess one for the non-NULL case, and one for the NULL case? -- Michael --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6X7XwACgkQnvQgOdby QH0CHxAAoeyoZLahi9MIuwjb3us70Twfi9/wjm8wZHlmVL/PISg9HV0drgBLl+hk Nch6rd7pTYDOFrLI6vluNWK94XJ+kS+Bw/LI57fBxT9+dO1blhVi8r0Ar9WHWRqX 0j8lTHxvH/Kp3PoHaTm4RBPEf8+15Of/drDgwnP6J8HlKlGPbGSTbnAFcOFYPDal CtFRUnFhHIDhS/8GMvyyhtBuM7StIB7Ft0HnEQXHqtElzG0i9l0pVM6vRJkNgXeY kkYT26PabYmaUsR5lcJ+Mj/NS9UyC0EnnD72rGRgILk+pJHBuw1XgZjqnW05qYYr tCJRiY62V4gzqdjggsGjH82CD8LTxO0Jr4NKyh0z2YpQw5ZVDvDeE32qfPgjiXmX kM7Qhdfigs+U4T2DtpaYbtRzzG5CP+9h60KJTF13IqcUgrmXP4aHA/TxagCtKXWF SOerGrbbzBSK0LMGqGfaJLyWiDQI73C8TXVE+ah2hdPpDdc4paQlWHhVR9eNOmpY VuSlxR5m11rhwLFYrKSuU/KGxjEh208wIcwPun5ow5MTUW/OosyjBR91ItFzgXIk mZgzr5iWo0ewuKGIptXi4MH+az3XfS36Tf/Wr6/gi5RZyY8ai2cNjEJD5i1EGVRo MS6XJfN9GOivuXr9FwW8rAutZEgfLjI+Qya5jl/sDhe47Ddnvpo= =Pbf3 -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--