Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPjnY-0005nq-Hd for pgsql-bugs@arkaria.postgresql.org; Sat, 18 Apr 2020 09:30:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jPjnW-0004gI-LW for pgsql-bugs@arkaria.postgresql.org; Sat, 18 Apr 2020 09:30:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPjnW-0004gB-FJ for pgsql-bugs@lists.postgresql.org; Sat, 18 Apr 2020 09:30:02 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPjnU-00030n-Fk for pgsql-bugs@lists.postgresql.org; Sat, 18 Apr 2020 09:30:02 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C76DA818; Sat, 18 Apr 2020 05:29:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 18 Apr 2020 05:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=f5T4V8iYfKwB49TCqItBJpknJEp 8FGDck5BNRlD8AY4=; b=czO29L+YhJbowUElYaPGZsKchtdNg2sqEsDORaVEFo7 //1MxIrxm8WK0T8OpBdjlSqu/bmq9TRqs0da2KyOSW95WRwQDk5aN57w8jgfLeFC DDRbZ+IveudlfECskkRIeQGgt615uO7JShle6wpfArcRLwlVjbFIM8ZXw1eYMSZx OO7/He/0uQtc92hbOUktHfQLf39bhaZWz32cRQQ9n/qx5qvAJRGRxU2Bw+HBV+sN wfSGX47310hosPTnShDeHITzd3XDEj6JiGGd5BvPv3iBKBLkzw1/KuhOmXGZJK// N/CMdilT9K7VNmUNyx6q6v3u2fdouikyrduVYwWpVxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=f5T4V8 iYfKwB49TCqItBJpknJEp8FGDck5BNRlD8AY4=; b=LORT4JfrQO3V1VW6tXVwRu k7JsMIXv1R9E/LH+RoCj0M91mHUmVV0iX6J60DRGsNLftKqlq58ew0cx12/07g/a A6TJCMMqjAYSRthZQI2tZRww3bj6+EcvK+Z8Dw+Mcnw1WPLWyM1/GH9yg8Vtzrml p1qHJ1YDDAVYpvr3Fb4kl39PRjEtPefcD25/+MeG9K9uUJ+3VUZS0F+uoVy32yRc YPgfsGuf56diwk4FQUSDkuF5d8afAEzatwUC54SmNtpMi4U6kWK0Q+sWywgJeJ4Q XQbq5EE6SwK5SjQ9sPybx/Y10cJ44zEob+o3vjnj7bS5EvY88h3PtG/LySKaC/dg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeelgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesph grqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id D5E5E3060064; Sat, 18 Apr 2020 05:29:05 -0400 (EDT) Date: Sat, 18 Apr 2020 18:28:56 +0900 From: Michael Paquier To: David Rowley Cc: Tom Lane , cameron.ezell@clearcapital.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns Message-ID: <20200418092856.GE350229@paquier.xyz> References: <16369-5845a6f1bef59884@postgresql.org> <1047.1586994741@sss.pgh.pa.us> <20200416053036.GA81957@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t4apE7yKrX2dGgJC" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --t4apE7yKrX2dGgJC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 18, 2020 at 02:13:17PM +1200, David Rowley wrote: > On Thu, 16 Apr 2020 at 17:30, Michael Paquier wrote: > > Shouldn't you have more regression test cases here? I guess one for > > the non-NULL case, and one for the NULL case? >=20 > Yeah. I've just pushed a fix that included a fairly simple regression tes= t. Thanks for the commit, David! I was wondering if it would have been better to add a "\pset null", but that's a nit and the result looks fine anyway. -- Michael --t4apE7yKrX2dGgJC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6ayFgACgkQnvQgOdby QH187A/+ImGpKDwDNXhFklp0rqLYnpHjQUEeMlmO+1beJNmoT3WtFfmCufFp0Wgt 35rSrDv69Rjt+1l/PaCYE1+NSACBmNedUfuYsAmADd7b+8lIpFPkAhTjsi9LY0xr 5bhPgE1OzJq3DoRLeAw2DJViYUER72bjQXVpijAISxVpur5jE0bImGGZeRsszFqU NBIAecitlYrL3noFYrAw7PO3zq5kv6iBJDUtwztwZE8zivY8CnC6td0Gzoj5ZzLg gHczFi2ysLNtaigldYfn3VWW186g0wzxHJiy1yuerB1/AiqlJQS3g1ySeSGd+WWt lK1zsqq8EUB5669MTjDOBrEs9rMxyh+xOntagZLlfFTZrXdmJ0cOsOrTfYw4QqWA Qtf4whjWyVuGGkxUYFXxCJG7oFE818psJBMeJj6StjACdpUg+8+mt4SNBh8Oefuk kedjUjOBYSKiB0I7XhWsla0F9jvRqVTFAD10POZGbbfFO6BDf3wDTNY3Kcgp2pKE ju56PDw8BeV/U7Hq94Fir+8Vfx5D+ci65sj7Lfffjo3HdlWME+OsLsxOtoxJsxnx I+NNYalKrfkadUhpt80a8vOHcp8hKzkCPAPLGun6Mkhd2Y9ojhqS0Mn758KmpuQt uv+bPVt+6W2TPYUcNXCvR9Gswnj7ppK2Hv9fclDV536OnQys3qQ= =o9CH -----END PGP SIGNATURE----- --t4apE7yKrX2dGgJC--