Date: Tue, 21 Apr 2020 11:15:01 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Message-ID: <20200421021501.GE77439@paquier.xyz>
References: <20200417065043.GC350229@paquier.xyz>
 <20200417153304.01a226cc@firost>
 <20200418092611.GD350229@paquier.xyz>
 <20200420.160231.719176619682386260.horikyota.ntt@gmail.com>
 <20200420073444.GA77439@paquier.xyz>
 <20200420142235.1536a73b@firost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XRI2XbIfl/05pQwm"
Content-Disposition: inline
In-Reply-To: <20200420142235.1536a73b@firost>
Precedence: bulk


--XRI2XbIfl/05pQwm
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 20, 2020 at 02:22:35PM +0200, Jehan-Guillaume de Rorthais wrote:
> The problem is that we would have to read the controldata file each time =
we
> wonder if a segment should be archived/removed. Moreover, the controldata
> file might not be in sync quickly enough with the real state for some oth=
er
> code path or futur needs.

I don't think that this is what Horiguchi-san meant here.  What I got
=66rom his previous message would be to be to copy the shared value from
the control file when necessary, and have the shared state use only a
subset of the existing values of DBState, aka:
- DB_IN_CRASH_RECOVERY
- DB_IN_ARCHIVE_RECOVERY
- DB_IN_PRODUCTION
Still, that sounds wrong to me because then somebody would be tempted
to change the shared value thinking that things like DB_SHUTDOWNING,
DB_SHUTDOWNED_* or DB_STARTUP are valid but we don't want that here.
Note that there may be a case for DB_STARTUP to be used in
XLOGShmemInit(), but I'd rather let the code use the safest default,
DB_IN_CRASH_RECOVERY to control that we won't remove .ready files by
default until the startup process sees fit to do the actual switch
depending on the checkpoint record lookup, if archive recovery was
actually requested, etc.

> Indeed, Beno=EEt Lobr=E9au reported this behavior to me.

Noted.  Thanks for the information.  I don't think that I have ever
met Beno=EEt in person, do I?  Tell him that I owe him one beer or a
beverage of his choice when we meet IRL, and that he had better use
this message-id to make me keep my promise :)
--
Michael

--XRI2XbIfl/05pQwm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6eVyUACgkQnvQgOdby
QH1Ulw/8DdCahK7Ihv5VyG2WDienBRsOYde2vn6dCkMpuQ8ATB8kt7QtxHrJU+tW
cEDyBjBfSvw2q6gWzu1LyfZNETVYc2otwfl7QDNyCybPInDl38MPT18qQfncNzrF
koyx1i3rQWahTULCblUYQMoeQaMd1kQsRolH93OwpNo6jtyfoQ2MG4QpoVvdiJ+t
hCrE9Ws9JVWdIUygETYlOS+B8PjWI7G+AJVk3Xet6kQqfXxGgSXhPZlC9b/UCCet
p0GPETMoc6RLFx1pwtHO4wToBCg2uYoTtKJRBm8sHtYLKAfGaJvQex1nrzHUfVIJ
Audm9RRS2m8zqHdBQ/sEjcPXSjBo6QONP8EwSE5PxMA3UVigC/M8O6qSPsVFjIZG
58TAJ1cIqMVBm346iFQY57mkmmWFSjEnnQ5dHu/cWC3dkHWvQz48+a6cSW/vy7UD
EFuc1a/aNSj0SbSbAVME2Ee4Bd8tQw1P0q6HK1mFAqYfsRiHroCByEMtapIBh2CU
HRyHCzf+QaMImLR5DlPkjpOu9wsfm/YvVg/6mTiZu4cbWXBjTJgSyzKh4/NB7EG6
t3BsJZNQQF6mNgv2ctH9tkL0WU/CbZP19cFero+EHCEl4j/O4sPfwW1M/HNaozKh
n9xd52k9ZbZwRHy8dMEqFnYAw/BSXM1EGIQNaFnsfPDCBDHTOYs=
=j8KQ
-----END PGP SIGNATURE-----

--XRI2XbIfl/05pQwm--