Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQxcT-0004jq-UJ for pgsql-bugs@arkaria.postgresql.org; Tue, 21 Apr 2020 18:27:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jQxcS-0000QE-Qe for pgsql-bugs@arkaria.postgresql.org; Tue, 21 Apr 2020 18:27:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQxcS-0000Q5-Kf for pgsql-bugs@lists.postgresql.org; Tue, 21 Apr 2020 18:27:40 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQxcP-0008BZ-QY for pgsql-bugs@lists.postgresql.org; Tue, 21 Apr 2020 18:27:39 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1jQxcO-0002SA-Qb; Tue, 21 Apr 2020 14:27:36 -0400 Date: Tue, 21 Apr 2020 14:27:36 -0400 From: Bruce Momjian To: tureba@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16380: documentation: host[no]gssenc vs. address/IP-address/IP-mask fields Message-ID: <20200421182736.GG19613@momjian.us> References: <16380-45bf493d620bc29c@postgresql.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <16380-45bf493d620bc29c@postgresql.org> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 19, 2020 at 06:29:31PM +0000, PG Bug reporting form wrote: > The following bug has been logged on the website: > > Bug reference: 16380 > Logged by: Arthur Nascimento > Email address: tureba@gmail.com > PostgreSQL version: 12.2 > Operating system: Documentation > Description: > > Hi, > > I see a couple of inconsistencies in the documentation of the pg_hba.conf > file in v12+: > https://www.postgresql.org/docs/12/auth-pg-hba-conf.html (and /current/) > > 1. Near the top, there's a line saying "A record can have one of the seven > formats", then the followup list shows 9 formats. The ones on host[no]gssenc > were added to the IP-address/IP-mask section, but not to the address > section. I believe the intention was to have 11 lines there, with a > corresponding count at the top. > > 2. In the address and IP-address/IP-mask descriptions, there's "This field > only applies to host, hostssl, and hostnossl records." and "These fields > only apply to host, hostssl, and hostnossl records.". But those lists should > probably be updated as well to add host[no]gssenc (or to negate the logic, > saying they are not applied to local connections). I agree with your suggestions. I also noticed that pg_hba.conf is missing gssapi entries too, so I added them to the attached patch. too. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + --l76fUT7nc3MelDdI Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="hba.diff" diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml index 5f1eec78fb..d086d32c49 100644 --- a/doc/src/sgml/client-auth.sgml +++ b/doc/src/sgml/client-auth.sgml @@ -99,7 +99,7 @@ - A record can have one of the seven formats + A record can have one of the nine formats local database user auth-method auth-options host database user address auth-method auth-options @@ -409,8 +409,7 @@ hostnogssenc database user - These fields only apply to host, - hostssl, and hostnossl records. + These fields do not apply to local records. diff --git a/src/backend/libpq/pg_hba.conf.sample b/src/backend/libpq/pg_hba.conf.sample index c853e36232..2d76992886 100644 --- a/src/backend/libpq/pg_hba.conf.sample +++ b/src/backend/libpq/pg_hba.conf.sample @@ -9,17 +9,21 @@ # are authenticated, which PostgreSQL user names they can use, which # databases they can access. Records take one of these forms: # -# local DATABASE USER METHOD [OPTIONS] -# host DATABASE USER ADDRESS METHOD [OPTIONS] -# hostssl DATABASE USER ADDRESS METHOD [OPTIONS] -# hostnossl DATABASE USER ADDRESS METHOD [OPTIONS] +# local DATABASE USER METHOD [OPTIONS] +# host DATABASE USER ADDRESS METHOD [OPTIONS] +# hostssl DATABASE USER ADDRESS METHOD [OPTIONS] +# hostnossl DATABASE USER ADDRESS METHOD [OPTIONS] +# hostgssenc DATABASE USER ADDRESS METHOD [OPTIONS] +# hostnogssenc DATABASE USER ADDRESS METHOD [OPTIONS] # # (The uppercase items must be replaced by actual values.) # # The first field is the connection type: "local" is a Unix-domain # socket, "host" is either a plain or SSL-encrypted TCP/IP socket, # "hostssl" is an SSL-encrypted TCP/IP socket, and "hostnossl" is a -# plain TCP/IP socket. +# non-SSL TCP/IP socket. Similarly, "hostgssenc" uses a +# GSSAPI-encrypted TCP/IP socket, while "hostnogssenc" uses a +# non-GSSAPI socket. # # DATABASE can be "all", "sameuser", "samerole", "replication", a # database name, or a comma-separated list thereof. The "all" --l76fUT7nc3MelDdI--