Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR1zr-0007nu-Lk for pgsql-bugs@arkaria.postgresql.org; Tue, 21 Apr 2020 23:08:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jR1zq-0004hM-9Z for pgsql-bugs@arkaria.postgresql.org; Tue, 21 Apr 2020 23:08:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR1zq-0004hF-3n for pgsql-bugs@lists.postgresql.org; Tue, 21 Apr 2020 23:08:06 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR1zm-0001Ut-UL for pgsql-bugs@lists.postgresql.org; Tue, 21 Apr 2020 23:08:05 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4F31A756; Tue, 21 Apr 2020 19:07:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 21 Apr 2020 19:07:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=1PmNLOTZbnxxRiLzi+9n3nbcKs/ QLqoVZ253j0HrioA=; b=ee2vIHarB1ViGvlrto1B7mMicT4Sss89OrgFDv7Wi0F V9ExaXa9Xf5SmCtNnbRQwlSrBj9VWSFCsJ3dD3eyCPtzBamxR8p9t2mkbNd0aIFJ ngEf0CwJxpRRqK3wrVb313Zaq6qNzAltc8DV2l9ExWJZ9SH9L64ns9gWq9bd0wS5 jDSjBb9jkSZU9WK3O/BfPYhXnoap6mcdmAZHDTp80Op+9BJRhSkBU03mW5if/qEB OWvn7bP4mxdSTQB+5QxC/w71i3cF39qTqNvvF773vMk88rp5iedj6ssX4nFy12Xl AGxcy4DuCPkEraaggbqgeHsoVtPp36WR9kQJ+6E/7YQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1PmNLO TZbnxxRiLzi+9n3nbcKs/QLqoVZ253j0HrioA=; b=f5jb0A82MVN1kamdr+TnkM 25amYhJmihZhf5caguqj5C6oprPcGCugo4r72kSMBdtUSYjHYYxNl1AuLcRMtuSQ H3yzj15UER8Ibr8DtWt+YyoU+fbjhEE/dr6No6+tXujF0UMl7Q+5Vdxwfwh6nRLR 3x+PrdSaeocwy08PaTN6wCRSqrzJXP5/uz1x+6Fz8B4JtG2ERxg/BfuYK7oZLq7I vnl4qWpYu4uq0vwS0DU+4c3gOMX/q9JLhLXB/3DmVqNshhJF+r5IxAji0pVGblQv pZb7OxPtBJEVRKktT6JHWs8wZUvWCVSNvTXb1zx2K/oN+hl8KZqTHymhcUb4M4Dw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeeigddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecukfhppeduuddurddutd dvrddukedtrddukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 133C93065C96; Tue, 21 Apr 2020 19:07:56 -0400 (EDT) Date: Wed, 22 Apr 2020 08:07:52 +0900 From: Michael Paquier To: Jehan-Guillaume de Rorthais Cc: Kyotaro Horiguchi , masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org Subject: Re: [BUG] non archived WAL removed during production crash recovery Message-ID: <20200421230752.GD33034@paquier.xyz> References: <20200421021501.GE77439@paquier.xyz> <20200421.120925.76453535156648004.horikyota.ntt@gmail.com> <20200421045739.GC6436@paquier.xyz> <20200421.150817.1089565975398030716.horikyota.ntt@gmail.com> <20200422000022.7aa6a62b@firost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ns7jmDPpOpCD+GE/" Content-Disposition: inline In-Reply-To: <20200422000022.7aa6a62b@firost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Ns7jmDPpOpCD+GE/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 22, 2020 at 12:00:22AM +0200, Jehan-Guillaume de Rorthais wrote: > That leads me an idea where we would keep the ControlFile data up-to-date in > shared memory. There's a few duplicates between ControlFile and XLogCtl, so > maybe it could make the code a little simpler at some other places than just > fixing $SUBJECT using DBState? I'm not sure of the implications and impacts > though. This seems way bigger than the current fix and with many traps on the > way. Maybe we could discuss this in another thread if you think it deserves it? It seems to me that this could have wider applications than just the recovery state, no? I would recommend to keep this discussion on a separate thread to give more visibility to the topic. -- Michael --Ns7jmDPpOpCD+GE/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6ffMgACgkQnvQgOdby QH06gQ/+Mgq9f6S19quMd2JXswXgnOC3clxRr1syM8JSkY3s2qSIWDg3pCuylZwb 5qCQMmfexgjT7hPC48HMas+q+HSzFMbMEFw9g2HTkC7c3wEvQo1DO6j4bVPT4nFr Nz77qVyg8XvpKuoxrizqSJJEkIgzl6RofopSaS0R34W/WOn3rJFhpTq+LWa4YG3R CWjivYKeGeOMGlSeK5wQxb/6eWdanGl0+zYJE85VmTtN1G+uzb34wrk+nIIteJkq KVLaT3ENUELyPOuBW1jImW2ZD4YLqwkdbPwlTM8UG1sXRABdv5+PTvQaorjBPpSs pfIoGcBHv5OhIIA0YT+5lr0k28iJZzIeYs5vDtWlf4WwSjVIpViwi4oljZttQx8Y d7xiVOpRJusmmTVEF8xuAaJn0poy2erzovfsKDky5tEOhs33Fq+mKJC2gtDvwyfG D1+tEnOiw535kecWwVgrKZQ3ZoeEGdWiCjNN1dzFEguKCj+SP/3r75+GuhPE8DYz Pb9Dek6ZjkJYO2yQkZWar6AiyGaXCXdykKGkmOr/dyzNrSNniysZBC6AvjVAkUUV FJRPP8I0gm4dV45z/0VMUY6I1pYS1P/Sh73ACKH5JHAuHjN0WMyb4My8WUyoKEf/ y+7Iv9QS93Fxk3hgbWVbiAxpQF4AMSkcFbSvBn8EtQSaXpZMNlM= =vzWL -----END PGP SIGNATURE----- --Ns7jmDPpOpCD+GE/--