Date: Wed, 22 Apr 2020 10:19:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Message-ID: <20200422011935.GF33034@paquier.xyz>
References: <20200417065043.GC350229@paquier.xyz>
 <20200417153304.01a226cc@firost>
 <20200418092611.GD350229@paquier.xyz>
 <20200420.160231.719176619682386260.horikyota.ntt@gmail.com>
 <20200420073444.GA77439@paquier.xyz>
 <20200420142235.1536a73b@firost>
 <20200421021501.GE77439@paquier.xyz>
 <20200422004121.516a5a32@firost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RMedoP2+Pr6Rq0N2"
Content-Disposition: inline
In-Reply-To: <20200422004121.516a5a32@firost>
Precedence: bulk


--RMedoP2+Pr6Rq0N2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 22, 2020 at 12:41:21AM +0200, Jehan-Guillaume de Rorthais wrote:
> Do we need to acquire info_lck to look at the state here, as we do in
> GetRecoveryState()? Why is it missing from previous code where
> SharedRecoveryInProgress was protected by info_lck as well?

Please see 1a3d104.

> Plus, the new line length overflow the 80-column, but I'm not sure where to
> break this line.

pgindent has been run on v8, and it did not complain.

> In fact, this was inherited from 011_crash_recovery.pl where I originally
> added some tests. As 020_archive_status.pl doesn't use IPC::Run, the comment is
> wrong. But I wonder if this whole block is really needed. Unfortunately I can't
> test on MSWin32 :/

You are right here.  The restriction can be removed, and I have
checked that the test from v8 is able to pass on my Windows dev VM.
--
Michael

--RMedoP2+Pr6Rq0N2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6fm6cACgkQnvQgOdby
QH25JxAAiXNDllOPRWVMsPzygzH6MXJL3BiR5/picEccRwkkm8cqB/5Q87ERdlgu
IfhhRCNYVsHbnaqFTFSpKIYssfT6vxt5meROSsX8NZZJ0twchMlssLpUk7OviWlO
j211u2lkNrjXfnxV5m55+84OulE/WwIvZRGgevkST0GRiTzCdb5S4nek5+NL9qhh
czacojLEKcKEuLW28buUUzK8sd2Di/fVf9sJd7Ak8oDlFyK2U8HXmFwjYn6lO+4o
uir++MbbNGYyAFCZcYdaMMWzHifb86VR7Ll1IE4H0ifuIgboqeSI/dSlOcQa5CJK
YtJFPSzmoaNig9oAxoxY5OZUO7N7/6Rn9NIJxVLFFLu4MFKFU5DN0ySWjlkS103X
HEQ12HtjOJ6RWmsQy5BIhPN/CsLQRUnE+R9/aDQiIrJiWXdrmq34PyFEou1A9T5w
EeSt4BwHe7uetUShrq70JBSKhjDpVbMYcnClwvbPcttuT9hBH/B7IHyoP1EkMRra
9ixexDJygnaudNF9U8k7dXnvX3swEhQZfKrtODo6nW6ubhbqKYIJh9J0tGtca7xh
co1+jNbbU/p+U5Tu3Xa9U1R8B1f6RASjRwdPjpLv5hsYIMpzu4Ad0qcxwDYJ9DkC
/dJzC58w+TVk4Ynr2vsBVX4GaIbto3BPjuHDzlXqNS34UAma2VM=
=P43P
-----END PGP SIGNATURE-----

--RMedoP2+Pr6Rq0N2--