Date: Thu, 23 Apr 2020 08:46:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Message-ID: <20200422234618.GI33034@paquier.xyz>
References: <20200418092611.GD350229@paquier.xyz>
 <20200420.160231.719176619682386260.horikyota.ntt@gmail.com>
 <20200420073444.GA77439@paquier.xyz>
 <20200420142235.1536a73b@firost>
 <20200421021501.GE77439@paquier.xyz>
 <20200422004121.516a5a32@firost>
 <20200422011935.GF33034@paquier.xyz>
 <20200422073223.GG33034@paquier.xyz>
 <20200422175824.637bda91@firost>
 <20200422181717.491fb499@firost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="00hq2S6J2Jlg6EbK"
Content-Disposition: inline
In-Reply-To: <20200422181717.491fb499@firost>
Precedence: bulk


--00hq2S6J2Jlg6EbK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 22, 2020 at 06:17:17PM +0200, Jehan-Guillaume de Rorthais wrote:
> I found an extra useless line of code in v9 patch. Please, find in
> attachment v10. Sorry for this.

Thanks for helping here, your changes make sense.  This looks mostly
fine to me except that part:
+$standby1->poll_query_until('postgres',
+   qq{ SELECT pg_xlog_location_diff('$primary_lsn', pg_last_xlog_replay_location()) = 0 })
+  or die "Timed out while waiting for xlog replay";
Here we should check if $primary_lsn is at least
pg_last_xlog_replay_location().  Checking for an equality may stuck
the test if more WAL gets replayed.  For example you could have a
concurrent autovacuum generating WAL.
--
Michael

--00hq2S6J2Jlg6EbK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6g10kACgkQnvQgOdby
QH1OeA/+IQWkgsNnP0DdfFDmtWz3thGsJ+J49ZtWrWT5sO2fSemrUFLPeQnigDFF
U1m0lHZCFwRsU5nGuGqpNMy482b2w1w5UkraTFC9jYlklzRe4pPfGH/TvxINmAZn
4q8G3f9DfjKmkVly+hTrVlCOI3itshEIxCeOK6OSjZO2JM36PiMZ2xlSGSJz0V08
E7TZbOD0xyKJLDSA+a6S0fAvVYCTTOvrl15fEAJznER1Ws6uQSaow6cPBSh/d2tD
x6V2g2IOFO5JEJorUbIPN/AX7pFt/3zZuMj9mmjqCCrYpN6QcnJiF8BZt2gWMzl1
AHeJxFNBGinjwYQ65XID1Cq5l+hUPAzw1Kd4xfpAgwk//bJ40LCBB7SmFB5hj8F1
2qamlOei0818ht51gHglCAdyPZkdxOxkbYr5cgSpukHwzr53q9Hd+io3Ze5ecAQE
esevFY4feUKg6IyRSGkHKXdziORDd677O2pFJ76TCWqtZ1sR+hJXGw2QbEO86A2P
2zynf7quJ9w4t7sLXs65hyfGQkLlzi+r0bdDxrjYLkdN7qI3M0FCWOvZtq8OhDps
fTIBK41griOQRW/sL71zUKBLgvbrjf/EGccB1tasVRVw/v4BY+TZ7Jmd8N+k6rL4
BwkzGUFB07HXO15mW7Q/0ElW5MUvtdJIm63LcieiSVR+DGEASEU=
=lAkZ
-----END PGP SIGNATURE-----

--00hq2S6J2Jlg6EbK--