Date: Fri, 24 Apr 2020 12:43:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Message-ID: <20200424034248.GL33034@paquier.xyz>
References: <20200422175824.637bda91@firost>
 <20200422181717.491fb499@firost>
 <20200422234618.GI33034@paquier.xyz>
 <20200423.140546.1055476118690602079.horikyota.ntt@gmail.com>
 <20200423185953.5f8e5b8f@firost>
 <20200423235402.GJ33034@paquier.xyz>
 <25921.1587694875@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cnBsrynPgIOyCJkL"
Content-Disposition: inline
In-Reply-To: <25921.1587694875@sss.pgh.pa.us>
Precedence: bulk


--cnBsrynPgIOyCJkL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 23, 2020 at 10:21:15PM -0400, Tom Lane wrote:
> Looks like the news is not good :-(

Yes, I was looking at that for the last couple of hours, and just
pushed something to put back the buildfarm to a green state for now
(based on the first results things seem stable now) by removing the
defective subset of tests.

> I see that my own florican is one of the failing critters, though
> it failed only on HEAD which seems odd.  Any suggestions what to
> look for?

The issue comes from the parts of the test where we expect some .ready
files to exist (or not) after triggering a restartpoint to force some
segments to be recycled.  And looking more at it, I suspect that the
issue is actually that we don't make sure in the test that the
standbys started have replayed up to the segment switch record
triggered on the primary (the one within generate_series(10,20)), and
then the follow-up restart point does not actually recycle the
segments we expect to recycle.  That's more likely going to be a
problem on slower machines as the window gets wider between the moment
the standbys reach their consistency point and the moment the switch
record is replayed.
--
Michael

--cnBsrynPgIOyCJkL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl6iYHcACgkQnvQgOdby
QH1OLg/8CBdunbDwpTzNTSfU22lJDruYuCn1bW9KI2gM/Q/sFnptSBMnOGq4fDPp
yJbGZOu5e/FBhnDR1+XRZXQ1AlctRBf4ri8M5AY7QZlp7bgTdUEfNFAtpWEoabIY
doCdCJ+KUr05N3I6oSol1fm4koxV5iyMkl09JULNNIezXaBYzWxmKQWMQdL8texG
q9bjKLP5ON1WIYiWCIBCkUCBYZ3j/CRQNo0i7O189oChiskBs93XdIlVO1Qums1v
uxBLRunqwQWGNDH8VTkBJ8C0FuoP+20WeB+awIccON6rre2iHxaRmtUPdPbwZWRj
j5T9sSanaJldAuXVTzuReolKDskYDPjIDSBHVhMJmgHLiozQhStTR5ZlJuB8waM6
AJasB2l4pGlVOmCmZ7i/INVljGWJd8SZCQ93xmhM6JYyYzO+3PgvbujiNoICWDj6
y7Ekf5XNzeDcgmg3XAq5jJboJ3qm4B9xYlAGJHOsThaP/l++rO/gaBv1kwEV9No1
NOBkdXuhh3TZ/6h9Lcld13+6kdETXy2I0SKw8nfRt9lQTQFOvk7heACskR/vY3oS
z862DIbOv0LPHTzE0T5tw8fcPdnGNpiExj+L31g7ppnZ7eDPevjMh+Ju+tAzvcrS
Ry5FTT2hZ263R0owS4w04bKFgaZekEDIAYRUXQLNI2+TmQ/CQsY=
=Rc+R
-----END PGP SIGNATURE-----

--cnBsrynPgIOyCJkL--