Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlwmo-0003tp-VL for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jun 2020 15:49:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwmn-0001LT-JN for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jun 2020 15:49:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlwmn-0001LM-DG for pgsql-bugs@lists.postgresql.org; Thu, 18 Jun 2020 15:49:05 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlwmj-0000W4-6L for pgsql-bugs@lists.postgresql.org; Thu, 18 Jun 2020 15:49:04 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1jlwmc-0005iz-9B; Thu, 18 Jun 2020 11:48:54 -0400 Date: Thu, 18 Jun 2020 11:48:54 -0400 From: Bruce Momjian To: Stephen Frost Cc: Tom Lane , Jeff Janes , Michael Paquier , ram.maurya@lavainternational.in, pgsql-bugs Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match Message-ID: <20200618154854.GG7349@momjian.us> References: <16497-38bb1f1bcec44964@postgresql.org> <20200618080509.GH118592@paquier.xyz> <1549966.1592493410@sss.pgh.pa.us> <20200618152911.GF7349@momjian.us> <20200618154152.GB6680@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618154152.GB6680@tamriel.snowman.net> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, Jun 18, 2020 at 11:41:53AM -0400, Stephen Frost wrote: > Sure, most options to initdb need to be the same between the old cluster > and the new cluster, but this specific option doesn't have to be, since > we require that it's a cleanly shut down cluster, so why are we > complaining about it if it's different..? Did you not read my previous email that we might have added this so we can upgrade replicas? I am sure I can dig out the commit that added this and find the original cause, but running pg_upgrade on replicas is enough of a reason to me. Yeah, we could add a flag to pg_upgrade to allow this if you are not upgrading replicas, but why bother? It might even work if you create the new replicas with the same WAL segment size, but why add complexity for pg_upgrade, which is already complex enough. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee