Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlwtC-00049F-Vl for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jun 2020 15:55:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwtB-00015t-Tc for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Jun 2020 15:55:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlwtB-00015l-NG for pgsql-bugs@lists.postgresql.org; Thu, 18 Jun 2020 15:55:41 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwt9-0000ab-Iq for pgsql-bugs@lists.postgresql.org; Thu, 18 Jun 2020 15:55:41 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 898B45F7A7; Thu, 18 Jun 2020 11:55:37 -0400 (EDT) Date: Thu, 18 Jun 2020 11:55:37 -0400 From: Stephen Frost To: Bruce Momjian Cc: Tom Lane , Jeff Janes , Michael Paquier , ram.maurya@lavainternational.in, pgsql-bugs Subject: Re: BUG #16497: old and new pg_controldata WAL segment sizes are invalid or do not match Message-ID: <20200618155537.GC6680@tamriel.snowman.net> References: <16497-38bb1f1bcec44964@postgresql.org> <20200618080509.GH118592@paquier.xyz> <1549966.1592493410@sss.pgh.pa.us> <20200618152911.GF7349@momjian.us> <20200618154152.GB6680@tamriel.snowman.net> <20200618154854.GG7349@momjian.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="clAUy1/P5DkH44mV" Content-Disposition: inline In-Reply-To: <20200618154854.GG7349@momjian.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --clAUy1/P5DkH44mV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Bruce Momjian (bruce@momjian.us) wrote: > On Thu, Jun 18, 2020 at 11:41:53AM -0400, Stephen Frost wrote: > > Sure, most options to initdb need to be the same between the old cluster > > and the new cluster, but this specific option doesn't have to be, since > > we require that it's a cleanly shut down cluster, so why are we > > complaining about it if it's different..? >=20 > Did you not read my previous email that we might have added this so we > can upgrade replicas? I don't see how this option is related to dealing with replicas..? > I am sure I can dig out the commit that added > this and find the original cause, but running pg_upgrade on replicas is > enough of a reason to me. pg_upgrade can't be run on replicas, so I don't understand what you're referring to here.. The 'upgrading replicas' process that involves rsync also requires everything to have been shut down cleanly. > Yeah, we could add a flag to pg_upgrade to > allow this if you are not upgrading replicas, but why bother? It might > even work if you create the new replicas with the same WAL segment size, > but why add complexity for pg_upgrade, which is already complex enough. Users already have to deal with various options that need to be configured to match up between the primary and replicas, so this really seems like it's entirely independent of pg_upgrade and isn't something pg_upgrade needs to be worrying about.. Thanks, Stephen --clAUy1/P5DkH44mV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJe6455AAoJEO1sijiDR2RVVpkQAK1XDiGC0wKEHhPTWqq8wgcn QKAoL/SfIAlC4V1bJhKpZOYLKLSQHo16Lp9N0wD4xWTwWHZ/cFvUEG6TD4bPH7t1 57dBDHbqcT0Xz9mRFXlmcAtLDF3EJhmiVqnA/iMtElwIo1EjkFs/SQxPF9PTmsOj A62NHZTEV+6X4HMfpLJhozHZj6LgZFti/NcmXkyP1vGwOyNs5SgHlECLxogcHQwp 85DF0m/8eeDSV9gy9tC3Qe1/b2IBMgwtEoUzCGCbGn9MqCZp/mpB38NFmeDhZZ2E UgEkl+hy7/+NOQzLXLbjwrtMq70M2jntm0sEkto3HyBN6F7uU1iTAgeeIYEUjON1 0ukBATMv9mNCAa582ZdNBY9Sow00MolAWfYBymPXDbtxyAzGl2+yrmrftKmveg9I gfOdkXf+qAXTcqdfAFUBODQmTZ2Ymj8eF9S6V774EsVRymgZvCjOQVWc79ek+g8W 8/vf7sYSEsdOetQHK6ISZEWVWyeNruLDcxOXbZYQwZWVAZojLaMNgnyMysyJCHOm SUTA8+efDunVagJm/1Oz4JLc7VZjAltpi82Ao/uJHpWc06QZsVjMja/zW8+ZMxY3 v6HJbm+u6cw8fWxR7+lnC3XZtcQ4kSdMpT8BVCSEPFA3yvKZ2M3KnPR6uwEmkeME 2m0lR6tdA14VMDJ++6CQ =XhJS -----END PGP SIGNATURE----- --clAUy1/P5DkH44mV--