Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBple-0003Zx-Te for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Aug 2020 01:34:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kBpld-0003gr-RQ for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Aug 2020 01:34:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBplc-0003gi-4W for pgsql-bugs@lists.postgresql.org; Sat, 29 Aug 2020 01:34:53 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBplV-0006qk-9Y for pgsql-bugs@lists.postgresql.org; Sat, 29 Aug 2020 01:34:51 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 758095C00AF; Fri, 28 Aug 2020 21:34:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 28 Aug 2020 21:34:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=fHzaDCbpagg8e0BONwFjOH5n7r7 2Kbz4HNpUlfqbF7M=; b=FSb+TtJgOLLa19ADQRqHgjtpKsQPhXSDfnwhwh0Ibmg amTCU4LkBylkM4iLk5wKO7dogITWj9sLe2ZcrJ5BQ01PG83fHFt4EhYy6klqQKZP xsV53kNk545J0TflOJnvuDTSo0IbFZnj0WGIxpZu8+XGzBdExBM5Wv5xj4K2bgCN 7TAQ/tj+GyctedboUj4TvrJfICbhduq5ZU3oUCtaNu0w/AtgwzRx08KGDB3hALe9 P+RyKvJjvPiYTwv14CrgtwEV6DmEO9kuBYTw0uxAU+8O0YorVMty+nukOfhj1Qgk me4yjc8PEK7mA9Cn0fjzPzQMQl9uiKQYF/pIEjcOIfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=fHzaDC bpagg8e0BONwFjOH5n7r72Kbz4HNpUlfqbF7M=; b=S+D4WoZOlv0hoeoRSOQON9 C62Ail8nrO/931La+oenLDteFrVh/LEdhraRRkXy8CGniiF6g1AiAKswJVDKUeXr f4iECD6C9/kHypZnvSriDg/r43DUHwntsUAwxmBC994i07bAeeThb5K+EFmJAu9p 4GcIEutwowcIhelF9zH2S8wFm1Yh6raYrV9iFSYl+WvFUirvSRH6I30NEIh0LL5/ UznA3N20EDauwJJhGogVXzk7pM4ofk6mYyIdTTxgTCAee23CUejBVGg03xl/31zh oyKRSFx6XiOu3TvAEYO14d1hWgP19FbpzJKQD6HtiiSjRlFFe/eJU97peqws7uLw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeftddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepuddukedrvdeguddrvdehtd drgeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (mp76f1fa2c.ap.nuro.jp [118.241.250.44]) by mail.messagingengine.com (Postfix) with ESMTPA id AA8D830606FB; Fri, 28 Aug 2020 21:34:41 -0400 (EDT) Date: Sat, 29 Aug 2020 10:34:33 +0900 From: Michael Paquier To: Alvaro Herrera Cc: jan.mussler@zalando.de, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message. Message-ID: <20200829013433.GA1529@paquier.xyz> References: <20200827172519.GA5940@alvherre.pgsql> <20200827192218.GA5787@alvherre.pgsql> <20200827232242.GB21986@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <20200827232242.GB21986@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 28, 2020 at 08:22:42AM +0900, Michael Paquier wrote: > Yes, adding that to RemoveRelations() makes sense. Thanks for the > patch. I got some room to test the patch, and the place of the check looks good to me. I think that I would move the new check before we set PERFORM_DELETION_CONCURRENTLY for non-temporary relations though, as a partition tree can be temporary as long as all its members are temporary. -- Michael --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9JsKkACgkQnvQgOdby QH0ldQ/+NvE8ox5SlniDWkBZuR0Mk23G9z2AfU1kYDUdVvPyCl7l+yYOwmXY03GS N0mMWB0csb2BCaYIwvNazhequejxdW/dWBdfTSxZYVhxhW6hDbqPAfeHiraAoIdm gk5fdqRL09j3x7K0Izm6g1D/QTsCrpyfNRiZOf642s+RpTl78NI45DvuTEMb/cPH oVLqfQjj27ngCAkk8bq7x1fmTz80k1T8NYaLsOtmMGihAsXkoh7OuG9p9Bcz8W40 slW75uF4bDOuLywoKOM+xk46djDLLSdsNZRYodaIXp4pUKuXc0Z17Meuwx4iZI1X O9vGH9cSjL26Go22Y8SQL2nbmj7x+dozD8K8N+872eHuDQuZbn2YXeIL135YWbvi EGEgfulgcJa0GgqB5xxPjZYrynl3EPeVkxKKmuWTpdvYvBAno3U+IdYf7MrgeA7Y d2wrL6Va9np64JCDPMfhrcdZvr4Et+V5fozG/+ZxyUxykiOVR/ilvrHSpTCgXPtB Pgm31CGBcOhF8plW7ntfW9KtV0NM0Pnvqhu6LK1/TW/Vv2yIZVNFC4//oSWMsrdT A1RFU0ndt40EF/2/B5yUJtsc1d6Wx0Q7GxhWgYSZGu39uFuTmrsi/Au41HW+EoId urq94TIdlbmC1GTesrh6Zm46Nq3CS0B5ygRKx3XagWuVHuwAs+Q= =Jiq3 -----END PGP SIGNATURE----- --DocE+STaALJfprDB--