Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCpnN-00032Z-S3 for pgsql-bugs@arkaria.postgresql.org; Mon, 31 Aug 2020 19:48:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kCpnM-0006uX-Qy for pgsql-bugs@arkaria.postgresql.org; Mon, 31 Aug 2020 19:48:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCpnM-0006uQ-HX for pgsql-bugs@lists.postgresql.org; Mon, 31 Aug 2020 19:48:48 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kCpnJ-0004UY-Ra for pgsql-bugs@lists.postgresql.org; Mon, 31 Aug 2020 19:48:48 +0000 Received: by mail-qt1-x841.google.com with SMTP id b3so5621739qtg.13 for ; Mon, 31 Aug 2020 12:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=SypSw+TlNBxuILF6d25zre7xNVfjDvRaHKkXX+DGmXU=; b=O8SMLCVrEy7QY5O/UsHjr9UCaAXop+TvMHVIr+FnkMtBZEWnRHg5PstzGfMwPwI5EE 7u1eRs7So/2lFjTUqWV7enQF37CqWG/B+4DdtYPMYISEWdhQavqN24zxmAWbzfMis3iC z4aQyYc8MQL7x47kO5YOdW13kzdrFC5WKqxf2hiCdOKAnh2yvK+5tww7HM5WspZCOIAF hhYarv46npJB5safetSC/HjPrTvYPhxqPozTzmIAeGsZn9c3dUSL+jALNC1o1PltZcE9 MGv3Md/Pnjz2RWC24qmGYC4aXb15hlKjykmT05bxj1MMLFO1vV6J8CKIswUqWuGwHzYT UoeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=SypSw+TlNBxuILF6d25zre7xNVfjDvRaHKkXX+DGmXU=; b=EkuebIEd0HuCNkRNzlAk8GlwwvGIJRB0VoCrtAhefK2rUXPt7cGdGwxzkwJRGg/1Ij YBROAhbykoiDL2b0PP+NoIW71/3PHLMtT9DDb++V7fJBQn/zE8MXorfa4c3eqgnqk+bg onQsqunjqjoWcsBeeqBW0ymLl7rtAJOthOw6bSF2SIJZJDjM7X8qGexfPfQbcME/AxHJ IkM+wDH0iDvt7lc8I9wPJF8HqQb9FvbOh0WERkPiEHr1cXPdKBa25jXgtW3zXcCns+ih GLkBi8Vx16u99/lVglhKv/bXE+NzN1AbTBBebezlkDc+GV0iYH30uh0+KFJNqTus+8Kg Uy4w== X-Gm-Message-State: AOAM5326Vd91ZU1S+Ew2c18XKaqQK6L/Lf8TQ2j4Yv4RKu/LUnJOnBbg C3dlsLzDK9gP2VxQ2EPFzP1kOY+RhwBIenoslXl5mcO8tQhZIxI11dpgmCHIgANVEl/Yns+H/3K 3ULJZ4u619UUu5REanYCBXenqbeh/+JT+7x8VAGh22WeffLgbTkNu10kE7JgfSTOGTTOHsq9jle 9ZKgOktfFt/fSe X-Google-Smtp-Source: ABdhPJxZKXKg+t10WxHmOfb/HuQByez4rLrBQ+XslVUCFouoN92VlA49umsP/tMAXRrS/8lFsu4DVQ== X-Received: by 2002:aed:3c4c:: with SMTP id u12mr2788730qte.312.1598903323656; Mon, 31 Aug 2020 12:48:43 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id c185sm10712423qkb.135.2020.08.31.12.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 12:48:43 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 5671F2A0EF6; Mon, 31 Aug 2020 15:48:41 -0400 (-04) Date: Mon, 31 Aug 2020 15:48:41 -0400 From: Alvaro Herrera To: Michael Paquier Cc: jan.mussler@zalando.de, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message. Message-ID: <20200831194841.GA26160@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200829013433.GA1529@paquier.xyz> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Aug-29, Michael Paquier wrote: > On Fri, Aug 28, 2020 at 08:22:42AM +0900, Michael Paquier wrote: > > Yes, adding that to RemoveRelations() makes sense. Thanks for the > > patch. > > I got some room to test the patch, and the place of the check looks > good to me. I think that I would move the new check before we set > PERFORM_DELETION_CONCURRENTLY for non-temporary relations though, as a > partition tree can be temporary as long as all its members are > temporary. Good point. Will push shortly with that change. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services