Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kDSfq-0003Sk-7Q
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Sep 2020 13:19:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kDSfI-0007Mj-Mm
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Sep 2020 13:19:04 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kDSfI-0007Mb-GN
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Sep 2020 13:19:04 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kDSfF-0002HK-MT
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Sep 2020 13:19:04 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kDSfC-0004ti-82; Wed, 02 Sep 2020 09:18:58 -0400
Date: Wed, 2 Sep 2020 09:18:58 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	exclusion@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16486: Prompted password is ignored when password specified
 in connection string
Message-ID: <20200902131858.GD13613@momjian.us>
References: <16486-b9c93d71c02c4907@postgresql.org>
 <2090524.1591652199@sss.pgh.pa.us>
 <CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
 <2110959.1591655226@sss.pgh.pa.us>
 <2142411.1591667958@sss.pgh.pa.us>
 <20200901203846.GA13613@momjian.us>
 <CACACo5RDv3ahJ_whCmMRRqc6Y6C5XVStJ-kC5JJgiZ5KM7TRFA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACACo5RDv3ahJ_whCmMRRqc6Y6C5XVStJ-kC5JJgiZ5KM7TRFA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On Wed, Sep  2, 2020 at 09:54:37AM +0200, Oleksandr Shulgin wrote:
> On Tue, Sep 1, 2020 at 10:38 PM Bruce Momjian <bruce@momjian.us> wrote:
> 
> 
>     I used a later version of Tom's patch to add documentation of how
>     connection strings can override command-line options, plus it has the
>     password description improvements.
> 
>     I would like to apply this to all supported versions.
> 
> 
> Not related to the proposed change, this sentence is the same before and after,
> but makes me wonder:
> 
> > However, <application>psql</application>
>         will waste a connection attempt finding out that the server wants a
>         password.  In some cases it is worth typing <option>-W</option> to
> avoid
>         the extra connection attempt.
> 
> AFAIK, there is nothing in the protocol that forces psql to make an extra
> connection attempt.  If libpq provided a means to pass a password-prompt
> callback, no extra connection would be needed I think?

That is true.  I don't think we want the backend to be kept open waiting
for someone to type a password, which is why, I think, we don't do it
that way.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee