Date: Wed, 2 Sep 2020 19:37:15 +0200
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: pgsql-bugs@lists.postgresql.org
Subject: [BUG v13] Crash with event trigger in extension
Message-ID: <20200902193715.6e0269d4@firost>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/06PBa_U1mCKA/uP.0iNtdc+"
Precedence: bulk

--MP_/06PBa_U1mCKA/uP.0iNtdc+
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

Philippe Beaudoin reported to me a crash he was able to reproduce with some
extension update script. Please, find in attachment a script that triggers it.
Just edit the three first vars to point to a temporary installation and
instance.

Some git bisect shows the bug was introduced by b5810de3f4, where
multi-statement query strings are using different short memory contexts.

To make it short, any ALTER TABLE command in an extension script is 
currently calling lappend to add its command to the
currentEventTriggerState->commandList list from its own short context instead
of using the context of currentEventTriggerState.

Because of this, when we call EventTriggerCollectSimpleCommand() for the top
level "ALTER EXTENSION" query, the list has long been removed and a new call of
lappend on currentEventTriggerState->commandList raise
Assert(IsPointerList(list)).

Please, find in attachement a bug fix proposal. I did a very quick look at
other ->commandList manipulations in event_trigger.c. They all appear to
be in the correct context in a first look.

Regards,

--MP_/06PBa_U1mCKA/uP.0iNtdc+
Content-Type: application/octet-stream; name=bug-ext.bash
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=bug-ext.bash

IyEvYmluL2Jhc2gKCnNob3B0IC1zIC1vIGVycmV4aXQgbm91bnNldAoKUEdCSU49Ii90bXAvYnVn
X2V4dC9iaW4vIgpQR0RBVEE9Ii90bXAvYnVnX2V4dC9kYXRhIgpQR0xPRz0iL3RtcC9idWdfZXh0
L3Bvc3RncmVzcWwubG9nIgpQR0VYVERJUj0iJCgiJFBHQklOIi9wZ19jb25maWcgLS1zaGFyZWRp
cikvZXh0ZW5zaW9uIgoKZXhwb3J0IFBHUE9SVD01NDM5CgpybSAtcmYgIiRQR0RBVEEiCiIkUEdC
SU4iL2luaXRkYiAtVSBwb3N0Z3JlcyAiJFBHREFUQSIKCnRvdWNoICIkUEdFWFRESVIiL2J1Z2dp
bmdleHQuY29udHJvbAoKY2F0IDw8J0VPUycgPiAiJFBHRVhURElSIi9idWdnaW5nZXh0LS0xLjAu
MC5zcWwKQ1JFQVRFIFRBQkxFIHQgKCBpZCBURVhUICk7CgpDUkVBVEUgRlVOQ1RJT04gZXZ0X2Rk
bF9mbmN0KCkKUkVUVVJOUyBFVkVOVF9UUklHR0VSCkxBTkdVQUdFIHBscGdzcWwKQVMgJ0JFR0lO
IEVORDsnOwoKQ1JFQVRFIEVWRU5UIFRSSUdHRVIgZXZ0X2RkbF90cmcgT04gdGFibGVfcmV3cml0
ZQogIEVYRUNVVEUgUFJPQ0VEVVJFIGV2dF9kZGxfZm5jdCgpOwpFT1MKCmNhdCA8PCdFT0YnID4g
IiRQR0VYVERJUiIvYnVnZ2luZ2V4dC0tMS4wLjAtLTIuMC4wLnNxbApBTFRFUiBFVkVOVCBUUklH
R0VSIGV2dF9kZGxfdHJnIERJU0FCTEU7CkFMVEVSIFRBQkxFIHQgRFJPUCBDT0xVTU4gaWQ7CkVP
RgoKIiRQR0JJTiIvcG9zdGdyZXMgLUQgIiRQR0RBVEEiIC0tcG9ydD0iJFBHUE9SVCIgLS1sb2df
ZXJyb3JfdmVyYm9zaXR5PXZlcmJvc2UgLS1yZXN0YXJ0X2FmdGVyX2NyYXNoPW9mZiAmPiAiJFBH
TE9HIiAmCgp1bnRpbCAiJHtQR0JJTn0iL3BnX2lzcmVhZHkgLS1wb3J0PSIkUEdQT1JUIiAtcTsg
ZG8gc2xlZXAgLjU7IGRvbmUKCiIke1BHQklOfSIvcHNxbCAtLXBvcnQ9IiRQR1BPUlQiIC1YQXRh
IDw8RU9TClNFTEVDVCB2ZXJzaW9uKCk7CkNSRUFURSBFWFRFTlNJT04gYnVnZ2luZ2V4dCBWRVJT
SU9OICcxLjAuMCc7CkFMVEVSIEVYVEVOU0lPTiBidWdnaW5nZXh0IFVQREFURSBUTyAnMi4wLjAn
OwpFT1MKCnBraWxsIC1GICIkUEdEQVRBIi9wb3N0bWFzdGVyLnBpZCB8fCB0cnVlCgpybSAtcmYg
IiRQR0RBVEEiCnJtICIkUEdFWFRESVIiL2J1Z2dpbmdleHQqCg==

--MP_/06PBa_U1mCKA/uP.0iNtdc+
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename=v1-0001-Fix-crash-with-alter-table-event-triggers-in-extensi.patch