Date: Thu, 3 Sep 2020 19:41:14 +0200
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG v13] Crash with event trigger in extension
Message-ID: <20200903194114.34af669a@firost>
In-Reply-To: <20200902175328.GA21242@alvherre.pgsql>
References: <20200902193715.6e0269d4@firost>
	<20200902175328.GA21242@alvherre.pgsql>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/G27DIj1ZIcAkW5m118ue3TH"
Precedence: bulk

--MP_/G27DIj1ZIcAkW5m118ue3TH
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Wed, 2 Sep 2020 13:53:28 -0400
Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> On 2020-Sep-02, Jehan-Guillaume de Rorthais wrote:
> 
> > Hi,
> > 
> > Philippe Beaudoin reported to me a crash he was able to reproduce with some
> > extension update script. Please, find in attachment a script that triggers
> > it. Just edit the three first vars to point to a temporary installation and
> > instance.
> > 
> > Some git bisect shows the bug was introduced by b5810de3f4, where
> > multi-statement query strings are using different short memory contexts.
> 
> Good find.
> 
> I think we should turn your case into a proper TAP test so that we can
> incorporate it, for coverage -- the lines you patch do appear covered,
> but obviously not in these specific conditions.  I'm just not very sure
> *where* to add it; maybe src/test/modules/test_extensions is the place
> to have it, though that one doesn't have TAP tests currently.  An easy
> addition, though.

Sure, please find in attachment patch v2 adding a regression test.

Regards,

--MP_/G27DIj1ZIcAkW5m118ue3TH
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename=v2-0001-Fix-crash-with-alter-table-event-triggers-in-extensi.patch