Date: Fri, 4 Sep 2020 10:20:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: [BUG v13] Crash with event trigger in extension
Message-ID: <20200904012013.GE19499@paquier.xyz>
References: <20200902193715.6e0269d4@firost>
 <20200902175328.GA21242@alvherre.pgsql>
 <20200903194114.34af669a@firost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6cMF9JLEeZkfJjkP"
Content-Disposition: inline
In-Reply-To: <20200903194114.34af669a@firost>
Precedence: bulk


--6cMF9JLEeZkfJjkP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 03, 2020 at 07:41:14PM +0200, Jehan-Guillaume de Rorthais wrote:
> +$node->safe_psql('postgres',
> +	q{CREATE EXTENSION test_event_trigger VERSION '1.0'});
> +$node->safe_psql('postgres',
> +	q{ALTER EXTENSION test_event_trigger UPDATE TO '2.0'});
> +
> +my $ans = $node->safe_psql('postgres', q{
> +	SELECT extversion
> +	FROM pg_catalog.pg_extension
> +	WHERE extname='test_event_trigger'
> +});
> +
> +is($ans, '2.0', 'Extension test_event_trigger upgraded');

I may be missing something of course, but if this just tests a
sequence of SQL commands, why don't you just include a SQL test in
text_extensions/sql/?  That would be much cheaper than having to
create a full scenario with a TAP script.
--
Michael

--6cMF9JLEeZkfJjkP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9Rlk0ACgkQnvQgOdby
QH0p5Q/9GJM14Jf1z7pAziB3ScZXUpEB4oXFxnpyh/uXa/3gWK8gySxuJYPO9JSS
eCSk9vuksUefa/3KRX2aXGVickSXVcNT++9ki+dwWPifQnT2jQBnzxiVsSxk9EFB
B+RsiR/fmPQZ1Ax6bY6wp6Bz6YmPj5McBdlAkuNEaSakmDeX5DY7ucj8EbNeJSNH
8Dmysx7DSSUMLsMYkE7xoJaENYA9ODrkd6cjfbPHYWexn/xSPdLH1yFO0Tr3gzws
dho2gtYPEH4hakdS0CTEmIoaAVTbWjkQtYnaTT6K0QiswUCSSiUQMltqPFglQkey
GejjyXxdJJRne1HsiR2li2hT9CPSDAHluOsN4QBd50BT7rYspeRWKTMVPobSTlz/
8SFDh6rh45tQGru6yqfuK3rA4xYw9WAmeFAupogDg1YlpAR8JL3exbmU+EvFnQ33
s9JnpSzC2SCIGtWKk2PoD+rW7mPRJu/Ge1CHl8B4VDdoWRrCMl55+M8hDRAP4yqq
N2MFmhN0SnRdECInLR3hIDRp9KMA3VRyu//YrGltqBVR/qNKD24Wfkqb5jH+n9Ni
zzV+M7MxrqT5mbBV3FbshyEwJyM22/WY8P48EImJS3me6ebIkz+4b5qSBp/IS1LG
HBifrDlZrj2xslq+GWf9VWeWKpYvGywVKEEF66m+vXJ8rfek2oA=
=sKyN
-----END PGP SIGNATURE-----

--6cMF9JLEeZkfJjkP--