Date: Wed, 9 Sep 2020 01:55:53 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
	exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped
 tablespace
Message-ID: <20200908235553.7tbd6xjvnohv2xel@development>
References: <20200908074522.GG19261@paquier.xyz>
 <20200908213729.GA14993@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200908213729.GA14993@alvherre.pgsql>
Precedence: bulk

On Tue, Sep 08, 2020 at 06:37:29PM -0300, Alvaro Herrera wrote:
>On 2020-Sep-08, Michael Paquier wrote:
>
>> On Tue, Aug 11, 2020 at 04:04:07PM +0900, Michael Paquier wrote:
>> > Hmm.  Creating a file for partitioned table would be a completely new
>> > thing as well.  heap_create() has never created a file for partitioned
>> > tables since 10 so this could open to a new class of bugs.
>>
>> This thread has stalled for a couple of weeks now, and I would tend to
>> take the path where we'd basically revert 8725958 and ca41030.  That's
>> too late for v13 to do anything about that.  But not for 14.  Any
>> opinions?
>
>Well, naturally I oppose this idea.
>

Would it actually solve the issue? ISTM we'd still have to expect cases
with partitioned tables without storage, so presumably we'd have to do
something else ...


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services