Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzUs-0004kq-Ky for pgsql-bugs@arkaria.postgresql.org; Wed, 09 Sep 2020 12:46:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kFzUq-0000xc-5A for pgsql-bugs@arkaria.postgresql.org; Wed, 09 Sep 2020 12:46:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzUp-0000xV-VI for pgsql-bugs@lists.postgresql.org; Wed, 09 Sep 2020 12:46:43 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzUn-0006yV-Qn for pgsql-bugs@lists.postgresql.org; Wed, 09 Sep 2020 12:46:43 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DA8CD5C00D7; Wed, 9 Sep 2020 08:46:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 09 Sep 2020 08:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Mu3y7Pez/QdDQfF8HOz4wc9B12P KzStiyvB0Cp6/rlk=; b=2TWB6kTEeI5Ezxg04Py6buHDTYVjIY75UV+3nBdSjjm dQlX7n9kMYeMt5FIeqW9d6fC8lCseOaa8JpQpks9Tr1GDLKJ4GQNjmZx4EFVJHB2 maJ4OJCNm4Yd2DX/bauEKCVnhBx0lKGhEdY0/m+EOW9TARqnWaGB2CTpLPgZiwg1 TZARVwnYyMcVQQ6sNalL9eU4RZdOed3zoIVI0GuChGNaAddD7Cf0RJ5s8dRuJRSw rCb+oqcmaKg5QWhizN/UwpE3auTs2NjgB8FW5pFYuwMXgcnbHVYjMk4fBMKyNKBi q0N1VFTifG2+WEhvE/+Rr1ker5t2K5RcdUKwwNKkkIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Mu3y7P ez/QdDQfF8HOz4wc9B12PKzStiyvB0Cp6/rlk=; b=IQ6S+QPvU/OfgwLXA+SUoO EKqSKasG6JPIl+liQQALy9OqsiDolnpPKhMdU5yEbEw8Yv5QChB/wYT+Kfkgik53 HpVK8DXsTF8JYbAV6Dz35/I7RbhYBhwZpFr/i/PLnw15n2DzNJm1EIlH73f+wbqK YeeBJkzfRmqBE+nPh+djG9AwX7amSM1Y1rakSJNyVM+cnCwa88RJJWrusl9gALqG COsUIFG/VOvYV2VRR39n84OqMWxAyEDmE/v6JXKah7wewfewMtOBk7/7cGa/z0XR PTyMOTNkMT8cTzavD1lDo31SjW8Q1R9KUW/cOvtvkIqcxT5otp44EZIgI9lSkxCA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehhedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepudduuddruddtvddrudektd drudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id CBFDD306603C; Wed, 9 Sep 2020 08:46:37 -0400 (EDT) Date: Wed, 9 Sep 2020 21:46:34 +0900 From: Michael Paquier To: Tomas Vondra Cc: Alvaro Herrera , Tom Lane , exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace Message-ID: <20200909124634.GC2743@paquier.xyz> References: <20200908074522.GG19261@paquier.xyz> <20200908213729.GA14993@alvherre.pgsql> <20200908235553.7tbd6xjvnohv2xel@development> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ABTtc+pdwF7KHXCz" Content-Disposition: inline In-Reply-To: <20200908235553.7tbd6xjvnohv2xel@development> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ABTtc+pdwF7KHXCz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 09, 2020 at 01:55:53AM +0200, Tomas Vondra wrote: > Would it actually solve the issue? ISTM we'd still have to expect cases > with partitioned tables without storage, so presumably we'd have to do > something else ... I am not sure what you mean here. If we don't keep anymore references to tablespace OIDs in pg_class for partitioned tables, meaning that we don't leave anything dangling if the tablespace is dropped without any files in its location, how could that be a problem? -- Michael --ABTtc+pdwF7KHXCz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9YzqoACgkQnvQgOdby QH2Q2xAAlC+ORnT0eDx57ZAjK58D88o6//k9HOO6MssdTq1egIHg0jsorgNy8s5z McdrpmVOhEyR7pJpQvDXVxbOFoRNTv6uknMWyAiPk7DLC4ppCkbOCgblxHLo/ND5 XFsO2GOfhFq4XZkf89XXNPx1Gpt47VSBObWCfC7kAF2Avt0wU6P3TZIgCPonq0Hr jOvzZrga0/LxViTZZL+MRPyrXc2oEki3HsoMFlA60XBs/RfSzCKXx59kwj/m2hgg 8sCchH+uFELTOakryXjSgiRZ6J9eRIcTXACktB3uVFY65A7FMWvz4Irf9E8SdYny vj3kCAbKtwT2j7ScQ/+h7yt9E3llizRcdDcS/UPkQ+oDkGAVKXOtE3ifnPksnqUP 1AueXSNDW8KbG5AS65serH5ZS3O5Yt3+KrOV0m5VNeJEot6bBcicoMZNnkJX4z+/ X7tu9lrSJCO8SF22iUPyFex1ap6JIV2UVgEfiJ9+zqkvNMI+MzD+7/Xki0bjsHyk mGquM9SosMW5gr39tjXhJ5fchTAAWLUVo9Fus5H9PNcmnhp7Nd208CTRzpGNZc8b sttxV9OWFimwVTQeXvzoa/bn9C4v6bsl1fNGrWgK/DLyyjGHYewKYdOQmiUgV3dc CbgfMWIwLdsk+GzIv0ItfxPmS+fLqLAbYZxv6TE5RX3arVAh9zQ= =AmKx -----END PGP SIGNATURE----- --ABTtc+pdwF7KHXCz--