Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kILHg-0007dM-2Y for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Sep 2020 00:26:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kILHf-0003gD-0j for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Sep 2020 00:26:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kILHe-0003el-RB for pgsql-bugs@lists.postgresql.org; Wed, 16 Sep 2020 00:26:50 +0000 Received: from mail-qv1-xf42.google.com ([2607:f8b0:4864:20::f42]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kILHX-0007cX-PE for pgsql-bugs@lists.postgresql.org; Wed, 16 Sep 2020 00:26:50 +0000 Received: by mail-qv1-xf42.google.com with SMTP id f11so2700924qvw.3 for ; Tue, 15 Sep 2020 17:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bb4mUMmCO8BhVGtLPwTXuabownFdR7yIEo8shHb//LM=; b=emThuv7SvFNVcrAe0/ZJXTNtTvMEvC6+1pVCPPw0hO8pPOVIAlt1zDQND83khwydxb gzGYB2hB/mKeFnNz1gMdtH6RAo9gYOARZDv2sxouQxE1UIq7U76IZ6wVoLKcjDUGfI4D nKr8U8X/PM7dvZAZtj4WgYKjRpsWrA0eOyh9pZAoGOn5XcDhC9uK0p9cWNhSn7kiHc1P qDlMHMvj6qqpRMCvqep49qssseX2ZbXJs29d/IWBYSCUaijgVYMeh70Ipnfzk3/fra5s rghX0J7Pbzb7w16IG5I0UaaQp/hMU4hRvqTZn+AlAjwVYSU+aUK/jV898YLd732xZ292 F+Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bb4mUMmCO8BhVGtLPwTXuabownFdR7yIEo8shHb//LM=; b=HXAHnYtLdD1FL9dfytZ6nEgqzmTZyQDjRXUyTIzIluU+waAqVcoE/KtmbF+rqqHd4y x8lFlpcJ/YDPFoKuu4z5D/gYQDnPARR9wR+H8EA/rHwSqcXQKvyzq7YNoju5ZK1aXp87 ZZPXy7Fw/uBgQ4ys840whLhEXcCfVntc7JiY6idWF7ibv5yx2fW9oFeABjhGbZQKocby FdO9GBM8SkDTu0nC4HzCUYssxs3GL20u6Dwh4kIEMGch6XIEBrnebVvwvJ3Ln30lTm+E 3iNullB6IXcp4clIhnbxqnHnnmPTuuh3/6+/IUtsfkQvL4jOGxyf7JBrESSZqkIwKdgx +dzg== X-Gm-Message-State: AOAM531WZqA0crWvTA118hf1yMqf75FLddHM+WmINXrH8wpogyvTM7aW m5gcrl/aHDvRPdw/gGhJbipRxzoQPzTXwwTo X-Google-Smtp-Source: ABdhPJyStclZLQhf+ZSaTf971J/qHHyf7tCZPfNnwUxko7rea+58B29Yms/z2HDl8wbrYDqovFmhyg== X-Received: by 2002:a0c:e543:: with SMTP id n3mr20995518qvm.11.1600216001745; Tue, 15 Sep 2020 17:26:41 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id f64sm8659546qkj.124.2020.09.15.17.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:26:41 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 82D502A153C; Tue, 15 Sep 2020 21:26:39 -0300 (-03) Date: Tue, 15 Sep 2020 21:26:39 -0300 From: Alvaro Herrera To: Michael Paquier Cc: Jehan-Guillaume de Rorthais , pgsql-bugs@lists.postgresql.org Subject: Re: [BUG v13] Crash with event trigger in extension Message-ID: <20200916002639.GA21403@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200912002149.GK2743@paquier.xyz> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Sep-12, Michael Paquier wrote: > On Fri, Sep 11, 2020 at 10:09:00AM +0200, Jehan-Guillaume de Rorthais wrote: > > On Fri, 11 Sep 2020 15:14:41 +0900 Michael Paquier wrote: > >> FWIW, I think that the fix proposed is fine as-is, and that we had > >> better apply it. > > > > +1 > > Alvaro, would you prefer doing the final checks on this patch by > yourself and potentially commit it? I gave this a very long look and was convinced that it was going to break with multi-statement query strings, but it turns out that it wasn't. So I pushed it without any other changes. I forgot to add reviewer credit to the commit message :-( My apologies -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services