Date: Tue, 29 Sep 2020 20:22:25 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nagaraj Raj <nagaraj.sf@yahoo.com>,
	Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint
 definition
Message-ID: <20200929232225.GA16296@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2020-Sep-30, David Rowley wrote:

> I didn't go with the same wording.  The reason was that I didn't feel
> the word "constraint" had to be mentioned twice.
> 
> I won't object if you or Alvaro want to keep Alvaro's suggestion though.

*Shrug* this seems good enough.  A purist could complain that it is
redundant, but in practice it's not important.

Here's the proposed error message fix, using the wording that saves
$1.99.  I agree that trying to cram the constraint type in the primary
message is uglier.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--BXVAT5kNtrzKuDFl
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0001-Reword-error-message.patch"