Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNiaN-0000L8-He for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 20:20:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNiaK-0006Zo-VV for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 20:20:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNiaK-0006Zh-OV for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 20:20:20 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNiaI-0005j9-21 for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 20:20:19 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1kNiaG-0005yG-4Q; Wed, 30 Sep 2020 16:20:16 -0400 Date: Wed, 30 Sep 2020 16:20:16 -0400 From: Bruce Momjian To: Tom Lane Cc: "David G. Johnston" , Laurenz Albe , PostgreSQL Hackers Subject: Re: BUG #16419: wrong parsing BC year in to_date() function Message-ID: <20200930202016.GG26841@momjian.us> References: <20200904012149.GA13932@momjian.us> <20200904201224.GD6891@momjian.us> <663099.1601400389@sss.pgh.pa.us> <20200930175642.GC26841@momjian.us> <888835.1601489514@sss.pgh.pa.us> <20200930184216.GE26841@momjian.us> <892062.1601491831@sss.pgh.pa.us> <20200930190534.GF26841@momjian.us> <893081.1601493066@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <893081.1601493066@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Sep 30, 2020 at 03:11:06PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Sep 30, 2020 at 02:50:31PM -0400, Tom Lane wrote: > >> Actually, I was just finishing up back-patching the patch I posted > >> yesterday. I think we should just fix it, not document that it's > >> broken. > > > Agreed, that's what I wanted. You stated in a later email you couldn't > > convince yourself of the backpatch, which is why I asked. > > Oh, I see where our wires are crossed. I meant that I couldn't > convince myself to back-patch the make_timestamp() change. > (I'm still willing to listen to an argument to do so, if anyone > wants to make one --- but that part feels more like a feature > addition than a bug fix.) OK, at least this is addressed fully in PG 14 and beyond. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee