Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kNjd9-0002uM-0u
	for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Sep 2020 21:27:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kNjd7-0000d5-VH
	for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Sep 2020 21:27:17 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1kNjd7-0000cp-PQ
	for pgsql-bugs@lists.postgresql.org; Wed, 30 Sep 2020 21:27:17 +0000
Received: from wout1-smtp.messagingengine.com ([64.147.123.24])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1kNjd5-0006NK-Nj
	for pgsql-bugs@postgresql.org; Wed, 30 Sep 2020 21:27:16 +0000
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailout.west.internal (Postfix) with ESMTP id 57979F71;
	Wed, 30 Sep 2020 17:27:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
  by compute4.internal (MEProxy); Wed, 30 Sep 2020 17:27:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:subject:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oZmwS0gPtga/Vs5TP
	5W6n8BRHPmJmk4X19ClAFxGsP4=; b=nn7oYQfNOzUZRZP+InLIWO2BBFmDSHB6L
	xuSC5s6Y20YUZCU+iBgp3knkRN1lyCsIRYh05kIqg+/75kzzN3RCoyNeW80xnEml
	x26DHviRn40vO3LwizWtxZcX5vtqsqJ9pXU3NyBnG3GvXBFkYRFmaEPf6kAhIvIT
	UVuywu1HkZn0IlFVxs6KhZvceXcG4lG3vm/CpOKJHIYv6w3Atmm2CxuY8gXyoE7P
	YDFYxFDTjMumjzOTHvrj0gcfEK4OJR8btFumXcG0bNaQikK9fBrRA5yQwuEWmlwo
	axwAq9RPMq1IJSaC9U+CKpiguYT2sXsche8pP4oLUsyKPTCJLeAzg==
X-ME-Sender: <xms:Mfh0Xz18e3RR7zqmYuYphoRutj5ZmrzbXj9YL1V6t6BVWl3Y46yyIA>
    <xme:Mfh0XyHQZEDDbGZanskASRqmQS_Jj5AxE2q2AzBAz6oRHGK1gaEOOLfqqrcrudJ5c
    sIKkJhzZwPD2m7etA>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedujedrfedvgdduheekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfggtggujggfsehttdertddtredvnecuhfhrohhmpeetlhhvrghr
    ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe
    enucggtffrrghtthgvrhhnpeevgfelveegueejgefhgeetgefhgeehieefheehleetteei
    udeiiefhgffgheffteenucfkphepudeltddrleehrdduledrudegkeenucevlhhushhtvg
    hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl
    vhhhrdhnohdqihhprdhorhhg
X-ME-Proxy: <xmx:Mfh0Xz6ctnEIU1oOS4Hs_YUqnfny4i0o73Tq7eMAcwRkJq4u2cH-HA>
    <xmx:Mfh0X42mK40PFetwznKvPonInrTvCiV7bNUKICC91aG4xbsebMLnkA>
    <xmx:Mfh0X2FceF9G_3crGkMpwaPa2kxmk3a0VxU5tw1aq1oLy3HNbT1DIw>
    <xmx:Mfh0XxPD11Jxamv2xUwOWxkpGzk_wp8RKh4D_30t0nxBdjlw82dOGQ>
Received: from perhan.alvh.no-ip.org (unknown [190.95.19.148])
	by mail.messagingengine.com (Postfix) with ESMTPA id F3921328005D;
	Wed, 30 Sep 2020 17:27:12 -0400 (EDT)
Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000)
	id D81552A1B4F; Wed, 30 Sep 2020 18:27:09 -0300 (-03)
Date: Wed, 30 Sep 2020 18:27:09 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nagaraj Raj <nagaraj.sf@yahoo.com>,
	Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint
 definition
Message-ID: <20200930212709.GA4302@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvpPP=Wx4z=ko0HnGkD7QpRDQozgDVGqe4yi6q1bjgzvqg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On 2020-Sep-30, David Rowley wrote:

> On Wed, 30 Sep 2020 at 13:06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > > Here's the proposed error message fix, using the wording that saves
> > > $1.99.  I agree that trying to cram the constraint type in the primary
> > > message is uglier.
> >
> > WFM.
> 
> Looks good to me too.

Great, thanks, pushed now.