Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNljO-00006a-1f for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 23:41:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNljL-0002F9-Vd for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 23:41:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNljL-0002F2-Oz for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 23:41:51 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNljJ-0007RW-Ei for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 23:41:50 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1kNljH-0001xn-Ku; Wed, 30 Sep 2020 19:41:47 -0400 Date: Wed, 30 Sep 2020 19:41:47 -0400 From: Bruce Momjian To: Tom Lane Cc: Robert Haas , "David G. Johnston" , Laurenz Albe , PostgreSQL Hackers Subject: Re: BUG #16419: wrong parsing BC year in to_date() function Message-ID: <20200930234147.GI26841@momjian.us> References: <20200904012149.GA13932@momjian.us> <20200904201224.GD6891@momjian.us> <663099.1601400389@sss.pgh.pa.us> <911841.1601501743@sss.pgh.pa.us> <20200930223656.GH26841@momjian.us> <943476.1601508415@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <943476.1601508415@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Sep 30, 2020 at 07:26:55PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote: > >> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote: > >>> By that logic, we should never fix any bug in a back branch. > > >> No, by that logic, we should not change any behavior in a back-branch > >> upon which a customer is plausibly relying. No one relies on a certain > >> query causing a server crash, for example, or a cache lookup failure, > >> so fixing those things can only help people. But there is no reason at > >> all why someone shouldn't be relying on this very old and > >> long-established behavior not to change in a minor release. > > > That is an interesting distinction. > > I don't want to sound like I'm totally without sympathy for Robert's > argument. But I do say it's a judgment call, and my judgment remains > that this patch is appropriate to back-patch. Agreed. I was just thinking it was an interesting classification that no one relies on crashes, or query failures. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee