Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO8dE-0002Bv-4e for pgsql-bugs@arkaria.postgresql.org; Fri, 02 Oct 2020 00:09:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kO8dC-0000Z6-QY for pgsql-bugs@arkaria.postgresql.org; Fri, 02 Oct 2020 00:09:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO8dC-0000Yz-KU for pgsql-bugs@lists.postgresql.org; Fri, 02 Oct 2020 00:09:02 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO8dA-0002Z1-4F for pgsql-bugs@lists.postgresql.org; Fri, 02 Oct 2020 00:09:01 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D63FB5C00CD; Thu, 1 Oct 2020 20:08:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Oct 2020 20:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jS1G1jWFZLW8+WKoK jPNf7GUVDdmgn9orfoP/Bf0F4k=; b=fj4OVRJH4Jev1QZbGalNzdyh3ThSABnj2 lzV4KMK70CUyeD8O7KvyQ0VbOaiUzVNjfdicFcr5DurobtyhpKUSAjif+c4WFM7H SnZd/8QHLPA+d6iwI7wzRZBQNUTuUW9sfKfIFAnxd53XYwB0aVupLFOn/hlRfdn1 4YaUsv/gdUrH+24NBEJmQyDcwbSty44vfsUtf6e18p87jcoCxj5TgeLFlHkYPxEc SJZMrsc6BvLmkp0GyTV0eRsJBONiMcIp32bnUudrymfDXegm2aPfIVG251uXR+yU 13h8tETOJc5rsaQmW+rW2qRzZ+Q9152xBMBi8cmCSSMEUSI1wmdUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeehgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtuggjfgesmhdtreertdervdenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepieeghfelueduheegtdekjeehueffvddujefgteduieekjefh udefgeefiedvjeetnecukfhppeduledtrdelhedrudelrddugeeknecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhv hhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.148]) by mail.messagingengine.com (Postfix) with ESMTPA id C40A63064683; Thu, 1 Oct 2020 20:08:57 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id E6AD82A1550; Thu, 1 Oct 2020 21:08:54 -0300 (-03) Date: Thu, 1 Oct 2020 21:08:54 -0300 From: Alvaro Herrera To: Peter Eisentraut Cc: Tom Lane , Henry Hinze , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop Message-ID: <20201002000854.GA18560@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 2020-Oct-01, Peter Eisentraut wrote: > On 2020-09-30 23:32, Tom Lane wrote: > > The question that this raises is how the heck did that get past > > our test suites? It seems like the error should have been obvious > > to even the most minimal testing. > > What's the difference between this case and what the test suite is testing? > Is it that it replicates between two databases on the same instance? I don't know why the tests pass, but the message ERROR: error reading result of streaming command: does appear in the logs after running src/test/subscription many times (I see it in tests 001, 002, 013 and 014, apart from the new one in 100). It's indeed surprising that these tests all pass! I turned Henry's reproducer into the attached TAP test, and it does reproduce the problem; but if I reduce the number of rows from 5000 to 1000, then it no longer does. I don't quite see why this would be a problem with a larger table only. Do you? The fix is the commented-out line in walsender.c; the test reliably passes for me if I uncomment that, and the error message disappear from the server logs in all the other tests. --PNTmBPCT7hxwcZjr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Restore-double-command-completion-tags.patch"