Date: Sat, 10 Oct 2020 21:23:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Emil Iggland <emil@iggland.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15858: could not stat file - over 4GB
Message-ID: <20201010122353.GA2985@paquier.xyz>
References: <15858-9572469fd3b73263@postgresql.org>
 <CAC+AXB2164H1JjSOPwf=PK5AhRVHSApzC5NAU-443HSu7RotSA@mail.gmail.com>
 <160209800917.1171.12856112208955258625.pgcf@coridan.postgresql.org>
 <2831747.1602274940@sss.pgh.pa.us>
 <CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe"
Content-Disposition: inline
In-Reply-To: 
 <CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com>
Precedence: bulk


--G4iJoqBmSsgzjUCe
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 10, 2020 at 01:31:21PM +0200, Juan Jos=E9 Santamar=EDa Flecha w=
rote:
> Thanks for taking care of this. I see no problems in the build farm, but
> please reach me if I missed something.

Thanks for continuing your work on this patch.  I see no related
failures in the buildfarm.

-               _dosmaperr(GetLastError());
+               DWORD           err =3D GetLastError();
+
+               /* report when not ERROR_SUCCESS */
+               if (err =3D=3D ERROR_FILE_NOT_FOUND || err =3D=3D ERROR_PAT=
H_NOT_FOUND)
+                       errno =3D ENOENT;
+               else
+                       _dosmaperr(err);
Why are you changing that?  The original coding is fine, as
_dosmaperr() already maps ERROR_FILE_NOT_FOUND and
ERROR_PATH_NOT_FOUND to ENOENT.

-      _dosmaperr(GetLastError());
+      DWORD           err =3D GetLastError();
+
       CloseHandle(hFile);
+      _dosmaperr(err);
These parts are indeed incorrect.  CloseHandle() could overwrite
errno.
--
Michael

--G4iJoqBmSsgzjUCe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+Bp9kACgkQnvQgOdby
QH2IWRAAlODxua+iIAHo0EjJ5TyKkoiH5XsmJSR06AVdrhNTiBuNB2/8f9+3uWm2
SGXDKE5EILgySYWLPF8kbc3IrjnkhLgaNUnnFWfYSxaoU+uq1/qQu3CDTDQiY9IW
PJOn4Lek+3GYw09KvAAorU5UQ0YQod8H40e/6PLQx3H2ssv3p0mrZgYWakxtKdFB
HW7mHhBPsayvZUFzT15I7FS1y+kuTSk7IQTr+FxnK3Lae0aBcnAbsv7qYhgrtwRs
HzWKRZLJaBGjUb4lGyE0lkWqv++3urRZXg1XbxC2xWjwgbOVATUYGqT4jt2LFtwR
ymgq690JuRHsvlDJ6lCzJ7UIGJNxzn5YIVWSGYd82wm0f4kfpsd0a7u2MdolwDMa
6AxgkBhcTsyvC1ECNM6QiWQL06x3uzM0k8A8CVmEHP+V7vhowTcX9PxFg5W6O9c0
baIZAhCTWrvnTSWMFc4zqwtDjBXFpA8GxPfll3OeL+dQA1HQ5bO3RyUJYMV2CoNK
zSOGQi5+4AFFrBXZauMpEtdo1mdlvY8OSbarvdC1C35hE9KHpZ1FqgYsNWd8f0hX
cV6IjyGzde3u5pVUcDarA1t97OV/0DP+67ZcEkmcbKg3ALT25y7SbBOHyPYY+T5A
pSArOEpGPABp84DeDpB0u+1hBe1nVvsPL8pZjnQLl8JoTSvMWgU=
=ENmK
-----END PGP SIGNATURE-----

--G4iJoqBmSsgzjUCe--