Date: Fri, 30 Oct 2020 13:13:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped
 tablespace
Message-ID: <20201030041306.GF1693@paquier.xyz>
References: <20201028134045.GA6709@alvherre.pgsql>
 <1251838.1603893564@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zGQnqpIoxlsbsOfg"
Content-Disposition: inline
In-Reply-To: <1251838.1603893564@sss.pgh.pa.us>
Precedence: bulk


--zGQnqpIoxlsbsOfg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 28, 2020 at 09:59:24AM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> I haven't started on this one yet, but I intend to do so shortly.

Cool.  Glad to hear that.

>> Strictly speaking, we can still introduce a new category of pg_shdepend
>> entries in back branches; it won't break anything that works today.
>
> Yeah, as long as the patched version won't actively fail when those
> pg_shdepend entries are missing, I don't think a backpatch is too
> hazardous.  It might be worth checking that the extra entries don't
> create huge problems if one does downgrade after some of them exist
> --- but my feeling for how that mechanism works is that it'd Just
> Work, and indeed provide the missing DROP protection even without
> explicit action by the backend.

Good point.  Even with that, we have never considered the case of a
downgrade as something actually supported, right?  We had in the past
for example bug fixes that involve slight tweaks in the WAL records
that are upward-compatible, changing the way these get interpreted
when replayed, but it could be possible to finish with logical
corruptions or replay failures if a downgraded version replays a
slightly-modified record generated by a newer version, no?
--
Michael

--zGQnqpIoxlsbsOfg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+bktIACgkQnvQgOdby
QH3SVg/+Nw5hyedURxR3Ldf0VDiC/BQnzyc/10F2OOLyV8gdsAN/zMNSSXu+mF6V
KVK21C4eZIh+JDfPMA2xVa6d7OsTCl6pKnKHN57v+t00PmT9z9nQ04Qj126XzJWy
7ZHExYW4tWt4zevGz2KSbZhzh9QsJfAiQUd8t8FinYJXcwF/aYQjyicwSeFxpWI8
nogcd+wVkMZ0r6iCxxbGukfYs9mQgU8mpjIcU7VJCkDpk2WCIuu2MCYx8BmyCw+B
GKj7jhwSWOHPTTwUpy1BgVR9isCYb9dNjiTQLlnAAEqFW6QKDhiJchoEpr7UVNOb
W/lw6tYFKbkSw373meXd/itKtms+9d9UCCH0R+vlnrV8r9ILixR1JHtQAqkjG5rT
RKwzpAsyICJKe8w/AxGZx9QAfzUU5xKy/QuwqsRNIF1Vt2QWRcFJCnNwCuJckyrt
avwocylX1G3IhL3ZRdmFseQJJovf43u4azP+Qp5vBxqcuxHwpUq2xU6RRBME+xhC
tqx08hzC1C1gb8eL9lcPwDvDXmsns//xYTCrprXo+ruWzDA+ukUcUjWYs6qibQcV
rsUEh1TnExxXVsQkO7PkNTacAOs4PvXJP4Bz51rXjtskfTI0LvPC0L2VaFe4N4Rv
IY5VJ4mAyGcS5Vod2xAnRkX9CuUpmGlONPwLZQdp7S+sZKR+S/4=
=hYGm
-----END PGP SIGNATURE-----

--zGQnqpIoxlsbsOfg--