Date: Mon, 2 Nov 2020 00:33:33 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16486: Prompted password is ignored when password specified
 in connection string
Message-ID: <20201102063333.GE22691@telsasoft.com>
References: <16486-b9c93d71c02c4907@postgresql.org>
 <2090524.1591652199@sss.pgh.pa.us>
 <CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
 <2110959.1591655226@sss.pgh.pa.us>
 <2142411.1591667958@sss.pgh.pa.us>
 <20200901203846.GA13613@momjian.us>
 <428207.1599076060@sss.pgh.pa.us>
 <20200903190538.GA3248@momjian.us>
 <20201003021958.GC17425@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201003021958.GC17425@momjian.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Oct 02, 2020 at 10:19:58PM -0400, Bruce Momjian wrote:
> On Thu, Sep  3, 2020 at 03:05:38PM -0400, Bruce Momjian wrote:
> > On Wed, Sep  2, 2020 at 03:47:40PM -0400, Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > I used a later version of Tom's patch to add documentation of how
> > > > connection strings can override command-line options, plus it has the
> > > > password description improvements.
> > > 
> > > >          <option>--all</option>) is not used, the database name is read
> > > >          from the environment variable <envar>PGDATABASE</envar>.  If
> > > >          that is not set, the user name specified for the connection is
> > > > -        used.
> > > > +        used.  <link linkend="libpq-connstring">Connction strings</link>
> > > > +        can also be used for connection specifications, and these can
> > > > +        override other command-line options.
> > > >         </para>
> > > >        </listitem>
> > > >       </varlistentry>
> > > 
> > > * Spellcheck (not "Connction" please)
...
> > Sure, makes sense.  Updated patch attached.
> 
> Patch applied to all supported versions;  thanks for the report.

Unfortunately that included the typo Tom pointed out :(