Date: Tue, 12 Jan 2021 12:53:56 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	buschmann@nidsa.net, pgsql-hackers@lists.postgresql.org,
	Noah Misch <noah@leadboat.com>
Subject: Re: pg_upgrade test for binary compatibility of core data types
Message-ID: <20210112175356.GP4320@momjian.us>
References: <20191015001817.zei45apgpu5dzngr@development>
 <20191015044118.GO3599@telsasoft.com>
 <20191015070725.csmdmdvrlb6klwkg@development>
 <20201206180248.GI24052@telsasoft.com>
 <20201216172222.GS30237@telsasoft.com>
 <20201227190729.GB26311@telsasoft.com>
 <be693563-def1-2f5a-89c1-f4d3cb2ae716@enterprisedb.com>
 <20210112041352.GY1849@telsasoft.com>
 <20210112171559.GO4320@momjian.us>
 <20210112172753.GC1849@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210112172753.GC1849@telsasoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jan 12, 2021 at 11:27:53AM -0600, Justin Pryzby wrote:
> On Tue, Jan 12, 2021 at 12:15:59PM -0500, Bruce Momjian wrote:
> > Uh, what exactly is missing from the beta checklist?  I read the patch
> > and commit message but don't understand it.
> 
> Did you try to use test.sh to upgrade from a prior release ?
> 
> Evidently it's frequently forgotten, as evidenced by all the "deferred
> maintenance" I had to do to allow testing the main patch (currently 0003).
> 
> See also:
> 
> commit 5bab1985dfc25eecf4b098145789955c0b246160
> Author: Tom Lane <tgl@sss.pgh.pa.us>
> Date:   Thu Jun 8 13:48:27 2017 -0400
> 
>     Fix bit-rot in pg_upgrade's test.sh, and improve documentation.
>     
>     Doing a cross-version upgrade test with test.sh evidently hasn't been
>     tested since circa 9.2, because the script lacked case branches for
>     old-version servers newer than 9.1.  Future-proof that a bit, and
>     clean up breakage induced by our recent drop of V0 function call
>     protocol (namely that oldstyle_length() isn't in the regression
>     suite anymore).

Oh, that is odd.  I thought that was regularly run.  I have my own test
infrastructure that I run for every major release so I never have run
the built-in one, except for make check-world.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee