Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1l07Wd-00047m-AL
	for pgsql-bugs@arkaria.postgresql.org; Thu, 14 Jan 2021 18:39:15 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1l07Wb-0005qa-9B
	for pgsql-bugs@arkaria.postgresql.org; Thu, 14 Jan 2021 18:39:13 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1l07Wa-0005qT-9H
	for pgsql-bugs@lists.postgresql.org; Thu, 14 Jan 2021 18:39:13 +0000
Received: from out2-smtp.messagingengine.com ([66.111.4.26])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1l07WT-0007cq-TT
	for pgsql-bugs@lists.postgresql.org; Thu, 14 Jan 2021 18:39:11 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
	by mailout.nyi.internal (Postfix) with ESMTP id 1461B5C01B9;
	Thu, 14 Jan 2021 13:39:04 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
  by compute2.internal (MEProxy); Thu, 14 Jan 2021 13:39:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:subject:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm1; bh=rBW0hNlmMlwKwKd+SmHGx/sqwNnhHk2aOxRmgsL8YCk=; b=W6lWfI5U
	96oPXCroZYONdS1lRfnQwxrfe1OCtWDMDU2YuD2sRmvCTlvo/kdCw0VDIhNP1xRA
	ZPH0beT3sN73AG3trFJbyn5R7W2harJiCP1DOI9yPA1OUYuQgCif5yTzPP/kczqO
	EwTXtv/VtBshgquZ1+PA6ihWJJJtsVbtNetGXSM2y4MNrLi0kCA1uNXMzyGnpcZz
	9O+dbzPdqgHtGIu+4xAa/2YfFmUpeoHlXx5OLwJ2bW7wd/l1g4H2WoVHg6aZSa23
	VZBzw096Zayfbhq0HEp/0w3s/rkYIfdp8cvMu17joyGzVBjqIvRIKMNShAyyh27U
	OQyha3m/myZKkA==
X-ME-Sender: <xms:x48AYH9MM09IJ7jVsbGbsvjnkTLTlbF8ElHxlIBiHzzNioCVOoT7_A>
    <xme:x48AYDvIm75SFLwSIILACoHhKS7vwGFincSDZ67GUCOS_Q0GaLBRuJsyTKgbabtVs
    tzOZzPc2UvGbLhpgQ>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgeduledrtddtgdeltdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhvrghr
    ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe
    enucggtffrrghtthgvrhhnpeeufffhjeeiueeuffegvddukeegledtveeivdeiueefieei
    vefgteehueefteehvdenucfkphepudeltddrleehrdduledrudejjeenucevlhhushhtvg
    hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl
    vhhhrdhnohdqihhprdhorhhg
X-ME-Proxy: <xmx:x48AYFCb_dVlGlFV3xr4wWpg-ZOAQDokUAyZPgnzV7r_0BSR3QmW4Q>
    <xmx:x48AYDdtKMmmp_7sS2XO2PGvaaoUhY5NAApKjgsuKx771bqYH-Y90w>
    <xmx:x48AYMOuTZX8YMNlrcl-hmiZMoxIEodd-9-aKcImo5J0ilVokzy9zg>
    <xmx:yI8AYG1IVRd4oH-C7ziiegf_Sn66icG1sYGzwjdI2ORZLz7CFZ6gyQ>
Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177])
	by mail.messagingengine.com (Postfix) with ESMTPA id 3500224005E;
	Thu, 14 Jan 2021 13:39:03 -0500 (EST)
Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000)
	id 757E62A0FC3; Thu, 14 Jan 2021 15:39:00 -0300 (-03)
Date: Thu, 14 Jan 2021 15:39:00 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped
 tablespace
Message-ID: <20210114183900.GA11776@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <X//NbVXkfNkQYBm/@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On 2021-Jan-14, Michael Paquier wrote:

> Yeah, SHARED_DEPENDENCY_TABLESPACE is much better.  Perhaps I am just
> too much willing to add unnecessary defenses, so I am fine with any
> decision you'll take here.
> 
> In short, I am fine with what you have.  Thanks for taking the time to
> sort this stuff out.

Thanks for the review!  Pushed it to 11-master.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W