Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNj03-0002jr-Go for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 21:19:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lNj02-0008DO-DP for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 21:19:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNj01-0008DH-BL for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 21:19:10 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNizv-0006d3-7R for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 21:19:08 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E16A35C00C4; Sat, 20 Mar 2021 17:19:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 20 Mar 2021 17:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=KMXdo+mv8Ixusfb9+MpgKhMtvGW AwQDip5wjq3MiBmI=; b=kh1ujaiA8j88HHzmWwjPnxzTmbqBdX5WdSSZ/CYQNdD 9hV2QI+QLwaybJgF9Sg4gku17PSFEJIK9h/hh9xSE+k8e/IoeOMmUlZz3ayxvekC 4WK4KZXznbXRPxZDC9ZLVLq9dvj92Ox7pw1qaRqc86YVx46U7xurs4NlTCVKBQpX mFIzLG8Rdalr2AbonguQmDWo4lrqWKP0flhka6+o9Jt5sH/iuGz9Nf0vwOPeLMU0 irx8e/6kkQxaUt52xlZOdshiL9nJ+IupNJpCJr4e1aQWJRoEq6NgaCxxBEv7WvUM gDQX146eUTBxS4nQhsAc8GrGI1CplFWePMEl6o3dKaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KMXdo+ mv8Ixusfb9+MpgKhMtvGWAwQDip5wjq3MiBmI=; b=cvzk67iL/G/FZIf3kbkJWN KZXeRraEtcoZ3x+Gk5areXMAG5LT5xQC6fShMHxulE9d53wLlhnurPZdy9Rw6Z7f Q+hT3NhoWbXPOb2/OwzwEHFrUQ3uYMPZY1RT81N9sKS8VHPfwqDKklLg+i8wniov BtCJ/LKPecdYUNbWK082bTC522B0NFbkpRrFXG5c34rREaqmf2dJf2XM+V/lho+O LJfSFkrUjljtjVi0dJQDx636EYCgtkUdJEeRPobFp8wqEmAIEDwtlAUKfh9UK6I6 AkCXArp5ibgUGF+ErExUKqiFojxqi9TMT8vA4BchWdUz+tRzY3EUNeyyzck4alNg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegtddgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecukfhppeeijedrudeitddrvddujedrvdehtdenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgiivghl rdguvg X-ME-Proxy: Received: from intern.anarazel.de (c-67-160-217-250.hsd1.ca.comcast.net [67.160.217.250]) by mail.messagingengine.com (Postfix) with ESMTPA id B400C1080064; Sat, 20 Mar 2021 17:19:00 -0400 (EDT) Date: Sat, 20 Mar 2021 14:18:59 -0700 From: Andres Freund To: Tom Lane Cc: Regina Obe , 'Heikki Linnakangas' , 'Juan =?utf-8?B?Sm9zw6kgU2FudGFtYXLDrWE=?= Flecha' , 'PostgreSQL mailing lists' Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head Message-ID: <20210320211859.bukyego7m3j4btfm@alap3.anarazel.de> References: <2730776.1615672184@sss.pgh.pa.us> <2735801.1615678739@sss.pgh.pa.us> <000d01d71869$2dabde70$89039b50$@pcorp.us> <0bf7c953-ea90-7c74-0f97-4e0e83d09dc9@iki.fi> <2850891.1615712! ! 197@sss.pgh.pa.us> <2 872301.1615744731@sss.pgh.pa.us> <000501d71932$7da0fa40$78e2eec0$@pcorp.us> <3009860.1615824779@sss.pgh.pa.us> <20210320001748.n5zkqsafuiwk7txp@alap3.anarazel.de> <362.1616200637@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <362.1616200637@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2021-03-19 20:37:17 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2021-03-15 12:12:59 -0400, Tom Lane wrote: > >> Although I remain worried about this being an ABI break, I don't think > >> we are locked into it until we get to beta, or maybe even RC stage. > > > Could it make sense to define sigjmp_buf as a union over the potentially > > needed implementations? That'd allow us to switch back without an ABI > > break if we discover a problem with the gcc approach. > > No, it'd still be an ABI break, because the setjmp and the longjmp calls > have to use the same implementation. Ain't gonna work if elog.c tries > to throw via mingw's longjmp() while some extension contains a PG_TRY > that uses __builtin_setjmp(). Nor vice versa. Yea, I momentarily forgot that we can't easily wrap setjmp in a function... I guess we could just make sigsetjmp set a flag that indicates which longjmp to use, but that's probably more complication than the issue / mingw warrants. - Andres