Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUzpx-00089r-Lc for pgsql-bugs@arkaria.postgresql.org; Fri, 09 Apr 2021 22:42:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lUzpw-0008Qy-I4 for pgsql-bugs@arkaria.postgresql.org; Fri, 09 Apr 2021 22:42:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUzpw-0008Qq-C1 for pgsql-bugs@lists.postgresql.org; Fri, 09 Apr 2021 22:42:48 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUzpu-0004Jo-F7 for pgsql-bugs@lists.postgresql.org; Fri, 09 Apr 2021 22:42:47 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2E9155C0094; Fri, 9 Apr 2021 18:42:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 09 Apr 2021 18:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=e65Pq6Vq+aUhTSEFNB5YcJ3DzEFFs/nKeemsgmomh5Y=; b=EHTEMOWd mU4CuC/9eD5jrpzEe+wfjR55g6mQLaz+hgzIWbkinGesF02JTd4JyjUScOzgl9yT ci4xsUwsEb1E9CrCR5QelQUTGqT30Ryp9QJyJaAjgSpdh+HEJrvoyAJvg4q4BwkB Fw22DWX9Tlq5jObLpj+p2Emu0HEnaA0RzM2uCSKqAhSrOaZJZ96ykOXKTWQvt/3d KDms8YoFSIq41Hq5ad8JdgS+4dlJCi/mqnLGJPDjMQ4iyYfOaVx1rPSVvtVF3S0j cdoDbTG9LytOHDfHVsPmpxLCxCd36EUDw4Z+Vi4RrJzE/BsRnYOF4309Z/riTG2u LkfodsT1Qkp3MQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekvddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjfgesthekredttderudenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepueffhfejieeuueffgedvudekgeeltdeviedvieeufeei ieevgfetheeufeethedvnecukfhppeduledtrdelhedrudelrdelheenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl vhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 309DE1080063; Fri, 9 Apr 2021 18:42:44 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id B859F2A0EDC; Fri, 9 Apr 2021 18:42:41 -0400 (-04) Date: Fri, 9 Apr 2021 18:42:41 -0400 From: Alvaro Herrera To: Fujii Masao Cc: zoulx1982@163.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16931: source code problem about commit_ts Message-ID: <20210409224241.GA32072@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38d5b3c4-3bbf-64be-69f5-5f50cd1f6c2d@oss.nttdata.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Mar-24, Fujii Masao wrote: > diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c > index 7ebd3d35ef..26bad44b96 100644 > --- a/src/backend/access/rmgrdesc/committsdesc.c > +++ b/src/backend/access/rmgrdesc/committsdesc.c > @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record) > appendStringInfo(buf, "pageno %d, oldestXid %u", > trunc->pageno, trunc->oldestXid); > } > - else if (info == COMMIT_TS_SETTS) You have not pushed this one, right? I think we should do it now. Thanks -- Álvaro Herrera 39°49'30"S 73°17'W