Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpJLx-0007FH-Px for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Jun 2021 23:35:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lpJLw-0000nk-8v for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Jun 2021 23:35:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpJLw-0000nW-0u for pgsql-hackers@lists.postgresql.org; Fri, 04 Jun 2021 23:35:48 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpJLp-00046C-VB for pgsql-hackers@postgresql.org; Fri, 04 Jun 2021 23:35:47 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 70523182F; Fri, 4 Jun 2021 19:35:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 04 Jun 2021 19:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=czu5S77iKn7MLJp4P9S0xXT0ZrGzfUXjc6rSguAZ7Ec=; b=kbofTCP5 3aKK9abdCi73i2psUKzOQt6s3XoU7PdX5XO83fNPwrGNlZ+mpBaYObq/EYIq3JI8 dHY74DPO0bRk/04JVR9qL1n+lmiOpS+PL3TfKNzU1WmQdDwZrc9lxYimw7ssjg/4 AhiSzInNPiITiTjlEm11KYwjjRbkXI6wPYR3OlvLLQXXMavfY0rrpGSGetLPeBiV bkfv0bPlWdYiiyFFNMgDg45LlMAWRl9zsdylgAjsI0sB312i51Psfvu9auv8mkKl mCgX2nvEQB7YFlYXLiRoaThAktwkPLScSazETicXZUvnE+GvJt+v5v3HjjIPJlYu h0kgfHP6NowK8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtvddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttddunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeeggeevveffveejffdutefhvddtgeeghffhgfeuhfefjeei gfevhfefleevtdduteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 4 Jun 2021 19:35:37 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id ECFF72A0D0C; Fri, 4 Jun 2021 19:35:33 -0400 (-04) Date: Fri, 4 Jun 2021 19:35:33 -0400 From: Alvaro Herrera To: Jeremy Schneider Cc: Andres Freund , "Drouvot, Bertrand" , Tomas Vondra , PostgreSQL-development Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace() Message-ID: <202106042335.o64q6dui5hu2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Jun-04, Jeremy Schneider wrote: > ERROR: XX000: could not open relation with OID 0 > LOCATION: ReorderBufferToastReplace, reorderbuffer.c:305 Hah. It seems to me that this code should silently return if rd_rel->reltoastrelid == 0; just like in the case of txn->toast_hash == NULL. It evidently means that no datum can be toasted, and therefor no toast replacement is needed. (As far as I recall, a table cannot go from having a toast table to not having one.) -- Álvaro Herrera Valdivia, Chile "¿Qué importan los años? Lo que realmente importa es comprobar que a fin de cuentas la mejor edad de la vida es estar vivo" (Mafalda)