Date: Sat, 5 Jun 2021 23:33:31 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Vik Fearing <vik@postgresfriends.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Petr Fedorov <petr.fedorov@phystech.edu>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost
 when extracting epoch
Message-ID: <20210606063331.GC297923@rfd.leadboat.com>
References: 
 <CA+hUKGK+K8NyS57tU841m1tSF6ha3W0udN2dw_Hbc=D_0OPbmA@mail.gmail.com>
 <ee683994-8f7c-aded-be43-543e66e68b94@2ndquadrant.com>
 <9a680979-ad76-4c3b-1bc0-403152cf49dc@postgresfriends.org>
 <5752.1590424827@sss.pgh.pa.us>
 <428767b1-6a18-cc5a-bb2f-a78bc306fae3@postgresfriends.org>
 <6816.1590426450@sss.pgh.pa.us>
 <7994.1590428104@sss.pgh.pa.us>
 <298489.1604188643@sss.pgh.pa.us>
 <829899.1604357408@sss.pgh.pa.us>
 <1090402.1604449334@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1090402.1604449334@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210606063331.GC297923%40rfd.leadboat.com>
Precedence: bulk

On Tue, Nov 03, 2020 at 07:22:14PM -0500, Tom Lane wrote:
> I feel like this is committable at this point --- any objections?

(This became commit 40c24bf, "Improve our ability to regurgitate SQL-syntax
function calls.")

> --- a/src/backend/nodes/equalfuncs.c
> +++ b/src/backend/nodes/equalfuncs.c
> @@ -2369,11 +2369,12 @@ _equalFuncCall(const FuncCall *a, const FuncCall *b)

> +	COMPARE_SCALAR_FIELD(funcformat);

equalfuncs.c has been using COMPARE_COERCIONFORM_FIELD() to ignore differences
in fields of this type.  Does this spot have cause to depart from the pattern?